Skip to content

Replace <cuda/stream_ref> includes with <cuda/stream> - #2520

Merged
bdice merged 1 commit into
rapidsai:mainfrom
robertmaynard:bug/remove_cuda_stream_ref_includes
Aug 20, 2026
Merged

Replace <cuda/stream_ref> includes with <cuda/stream>#2520
bdice merged 1 commit into
rapidsai:mainfrom
robertmaynard:bug/remove_cuda_stream_ref_includes

Conversation

@robertmaynard

Copy link
Copy Markdown
Contributor

While #2513 fixed all issues in rmm, we had another inflight PR (#2511) that used the old include.

Found by downstream failures in rapids-cmake ( rapidsai/rapids-cmake#1079 )

While rapidsai#2513 fixed all issues in rmm, we had another inflight PR (rapidsai#2511) that used the
old include.
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5740ae71-6670-40b3-9013-a217f7a3743f

📥 Commits

Reviewing files that changed from the base of the PR and between 4d9a8b7 and 1168a4b.

📒 Files selected for processing (1)
  • cpp/include/rmm/detail/cuda_stream.hpp

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated CUDA stream integration to improve compatibility and build reliability.

Walkthrough

The CUDA stream detail header now includes <cuda/stream> instead of <cuda/stream_ref>.

Changes

CUDA stream header

Layer / File(s) Summary
Update CUDA stream include
cpp/include/rmm/detail/cuda_stream.hpp
Replaces the <cuda/stream_ref> include with <cuda/stream>.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1168a

This is a localized include replacement with no actionable merge-blocking risk remaining after normal checks and review.

Possibly related PRs

Suggested labels: non-breaking, improvement

Suggested reviewers: miscco, vyasr, ttnghia

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: replacing outdated CUDA stream header includes.
Description check ✅ Passed The description explains the remaining outdated include and its downstream impact in rapids-cmake.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Aug 20, 2026
@bdice bdice self-assigned this Aug 20, 2026
@bdice
bdice merged commit c65202f into rapidsai:main Aug 20, 2026
30 checks passed
@robertmaynard
robertmaynard deleted the bug/remove_cuda_stream_ref_includes branch August 20, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants