ensure nightly builds always produce new packages, expand 'changed-files' lists - #2502
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe workflows now compute shared build timestamps and pass them to build jobs. Build scripts and Conda recipes use datetime-based metadata, including timestamped wheel versions. ChangesBuild metadata
Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build.yaml:
- Around line 38-39: Update every Conda and wheel package-build job in
.github/workflows/build.yaml and .github/workflows/pr.yaml to depend on the
build-details job via needs and pass its build-datetime output as the reusable
workflow input. Apply the change at .github/workflows/build.yaml lines 38-39 and
.github/workflows/pr.yaml lines 55-56, covering all package-build jobs in both
workflows.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8e59ba75-1d3f-4080-abd2-5373b3abd29a
📒 Files selected for processing (8)
.github/workflows/build.yaml.github/workflows/pr.yamlci/build_cpp.shci/build_python.shci/build_wheel_cpp.shci/build_wheel_python.shconda/recipes/librmm/recipe.yamlconda/recipes/rmm/recipe.yaml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pr.yaml:
- Line 104: Correct the repeated workflow filename typo by replacing
trigger-rbeaking-change-alert.yaml with trigger-breaking-change-alert.yaml at
all four locations in .github/workflows/pr.yaml: lines 104, 131, 166, and 200.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 258ed7a6-7cac-4671-890a-b44ef584a39c
📒 Files selected for processing (2)
.github/workflows/build.yaml.github/workflows/pr.yaml
|
/merge |
Contributes to rapidsai/build-planning#218
For wheels:
And for conda:
Other changes:
changed-fileslists to avoid triggering test jobs in PR CI when only.github/workflows/{build,test}.yamlare changedNotes for Reviewers
How I tested this
See rapidsai/cugraph-gnn#508