test changes to package-publishing workflows - #2458
Merged
Merged
Conversation
jameslamb
added
non-breaking
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThree reusable workflow ChangesCI Workflow Ref Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bdice
approved these changes
Jun 29, 2026
bdice
left a comment
bdice
left a comment
Collaborator
There was a problem hiding this comment.
Fine with me! Please revert once the testing is complete.
Member
Author
|
Thank you! Yep once the testing is done I'll put up and admin a PR switching the branch back to |
Member
Author
|
/merge |
rapids-bot Bot
pushed a commit
to rapidsai/shared-workflows
that referenced
this pull request
Jun 29, 2026
… semver tags for third-party actions (#585) Contributes to #505 * removes telemetry and source checkouts for package-publishing jobs (`conda-upload-packages` and `wheels-publish`) And other tiny things I noticed while doing this: * removes outdated comments about `setuptools-scm` (RAPIDS does not use this any more) * switches from `#v7` to `#v7.0.0` in comments on `actions/checkout` (improves clarity of auto-generated PRs to update that) * updates all pre-commit hooks w/ `pre-commit` hooks ## Notes for Reviewers ### Is this safe? I think so. `conda-upload-packages` and `wheels-publish` don't depend on anything in the calling repo's source or git history. The `rapids-release-build` check here sort of depends on git tags: https://github.com/rapidsai/shared-workflows/blob/ad100ac25a47afe772ed86ee69e6eabd6966a419/.github/workflows/conda-upload-packages.yaml#L110-L112 But doesn't get it from a local checkout... it reads the GitHub-specific environment variable `GITHUB_REF`: https://github.com/rapidsai/gha-tools/blob/d85a30d7a8930b079ef681a086e8f3646120c27a/tools/rapids-is-release-build#L11 ### Impact Reduces runtime of these jobs a tiny bit, and more importantly removes some network requests (a common source of CI instability). The impact on runtime will be larger for repos where `git clone` is more expensive. For example, on a recent `cudf` build on `main`, checking out the code took 14 seconds and telemetry-related things added around 4 seconds. <img width="1837" height="899" alt="image" src="https://github.com/user-attachments/assets/82c7119d-41b1-43e6-b2df-7d66f8567cb4" /> https://github.com/rapidsai/cudf/actions/runs/28378826926/job/84082197842 ### How I tested this Proposing testing this here: rapidsai/rmm#2458 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Gil Forsyth (https://github.com/gforsyth) URL: #585
3 tasks
jameslamb
added a commit
that referenced
this pull request
Jun 29, 2026
## Description Follow-up to #2458 Testing in `shared-workflows` is complete now that rapidsai/shared-workflows#586 has been merged. This resets all branch references for `shared-workflows` back to `main`. ## Checklist - [x] I am familiar with the [Contributing Guidelines](https://github.com/rapidsai/rmm/blob/HEAD/CONTRIBUTING.md). - [x] New or existing tests cover these changes. - [x] The documentation is up to date with these changes.
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I believe that we don't need a source checkout for the RAPIDS CI jobs that publish conda packages and wheels.
rapidsai/shared-workflows#585 is proposing removing checkouts and telemetry from those workflows, to save some time and improve CI stability.
Proposing that we merge a PR here in
rmmusing those new workflows to test.Checklist