Remove deprecated rmm.pylibrmm.cuda_stream module#2335
Conversation
The rmm.pylibrmm.cuda_stream module was deprecated in PR rapidsai#2256 (closing rapidsai#1782) when stream objects were moved to rmm.pylibrmm.stream. The module was left as a backwards-compatibility shim re-exporting CudaStream and CudaStreamFlags. Remove the shim module files (.pyx, .pxd, .pyi), the associated deprecation test, and the CMake build entry.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR removes the deprecated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Docs failure: I think this section can be removed: Lines 27 to 34 in b325755 |
TomAugspurger
left a comment
There was a problem hiding this comment.
LGTM once the docs section is removed.
Summary
rmm.pylibrmm.cuda_streambackwards-compatibility shim module (.pyx,.pxd,.pyi)test_cuda_stream_module_deprecation)cuda_stream.pyxfrom the Cython build sources in CMakeLists.txtThe module was deprecated in #2256 (closing #1782) when stream objects were moved to
rmm.pylibrmm.stream. Users should usermm.pylibrmm.stream.Streamandrmm.pylibrmm.stream.CudaStreamFlagsinstead.Checklist