Skip to content

Fix missing ulimit in CUDA 13.1 devcontainers#2309

Merged
bdice merged 1 commit intorapidsai:release/26.04from
bdice:fix-ulimit
Mar 16, 2026
Merged

Fix missing ulimit in CUDA 13.1 devcontainers#2309
bdice merged 1 commit intorapidsai:release/26.04from
bdice:fix-ulimit

Conversation

@bdice
Copy link
Copy Markdown
Collaborator

@bdice bdice commented Mar 16, 2026

Description

I found that the ulimit settings for CUDA 13.1 devcontainers were missing. This fixes it.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner March 16, 2026 17:25
@bdice bdice requested a review from jameslamb March 16, 2026 17:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2373bde8-c683-4d30-af68-9acb018ef079

📥 Commits

Reviewing files that changed from the base of the PR and between f15bf3e and 6541ade.

📒 Files selected for processing (2)
  • .devcontainer/cuda13.1-conda/devcontainer.json
  • .devcontainer/cuda13.1-pip/devcontainer.json

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Improved resource handling in CUDA 13.1 development containers (conda and pip variants) to support higher file operation limits and prevent resource constraints during intensive workflows.

Walkthrough

Two devcontainer configurations are updated to add file descriptor ulimit settings. The runArgs arrays in both CUDA 13.1 conda and pip configurations now include --ulimit nofile=500000 to increase the container's maximum open files limit.

Changes

Cohort / File(s) Summary
Devcontainer runArgs Configuration
.devcontainer/cuda13.1-conda/devcontainer.json, .devcontainer/cuda13.1-pip/devcontainer.json
Added --ulimit nofile=500000 to the runArgs array to increase the file descriptor limit for container instances. Trailing comma added to separate the new arguments from existing container name configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding missing ulimit settings to CUDA 13.1 devcontainer configurations.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of the change and confirming checklist items are complete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Mar 16, 2026
@bdice
Copy link
Copy Markdown
Collaborator Author

bdice commented Mar 16, 2026

/merge

@bdice bdice merged commit 2704255 into rapidsai:release/26.04 Mar 16, 2026
47 checks passed
@bdice bdice mentioned this pull request Mar 17, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants