Skip to content

examples: read tag from RAPIDS_BRANCH file #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Mar 12, 2026
+16 −8
Merged

examples: read tag from RAPIDS_BRANCH file #2293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb8ef5a
examples: read tag from RAPIDS_BRANCH file
jameslamb Mar 12, 2026
272bca5
use rapids_config instead
jameslamb Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ repos:
pass_filenames: false
verbose: true
- repo: https://github.com/rapidsai/pre-commit-hooks
rev: v1.3.3
rev: v1.4.2
hooks:
- id: verify-copyright
args: [--fix, --spdx]
Expand All @@ -120,6 +120,17 @@ repos:
)
- id: verify-alpha-spec
- id: verify-hardcoded-version
exclude: |
(?x)
(^|/)devcontainer[.]json$|
(^|/)dependencies[.]yaml$|
^[.]github/(workflows|ISSUE_TEMPLATE)/|
(^|/)pom[.]xml$|
^[.]pre-commit-config[.]yaml$|
^conda/environments/|
(^|/)VERSION$|
(^|/)RAPIDS_BRANCH$|
[.](md|rst|avro|parquet|png|orc|gz|pkl|sas7bdat)$
- id: verify-pyproject-license
# ignore the top-level pyproject.toml, which doesn't
# have or need a [project] table
Expand Down
6 changes: 1 addition & 5 deletions ci/release/update-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# SPDX-FileCopyrightText: Copyright (c) 2024-2025, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION.
# SPDX-License-Identifier: Apache-2.0
########################
# RMM Version Updater #
Expand Down Expand Up @@ -92,10 +92,6 @@ function sed_runner() {
echo "${NEXT_FULL_TAG}" > VERSION
echo "${RAPIDS_BRANCH_NAME}" > RAPIDS_BRANCH

# Examples update
sed_runner "s|RMM_TAG release/[0-9][0-9]*\.[0-9][0-9]*|RMM_TAG ${RAPIDS_BRANCH_NAME}|g" cpp/examples/versions.cmake
sed_runner "s|RMM_TAG main|RMM_TAG ${RAPIDS_BRANCH_NAME}|g" cpp/examples/versions.cmake

# CI files
for FILE in .github/workflows/*.yaml; do
sed_runner "/shared-workflows/ s|@.*|@${WORKFLOW_BRANCH_REF}|g" "${FILE}"
Expand Down
5 changes: 3 additions & 2 deletions cpp/examples/versions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# =============================================================================
# cmake-format: off
# SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
# SPDX-License-Identifier: Apache-2.0
# cmake-format: on
# =============================================================================

set(RMM_TAG release/26.04)
Copy link
Copy Markdown
Member

@KyleFromNVIDIA KyleFromNVIDIA Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specifically left examples alone because my impression is that they need to work outside of the context of the repo where these supporting files are available. If that's not the case, I support this change.

Copy link
Copy Markdown
Member Author

@jameslamb jameslamb Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @bdice on that, I don't know the answer.

Copy link
Copy Markdown
Collaborator

@bdice bdice Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most people building the examples will do so in the context of a cloned repository. We can always change this back if people report issues with building.

include(${CMAKE_CURRENT_LIST_DIR}/../../cmake/rapids_config.cmake)
set(RMM_TAG ${_rapids_branch})
Loading