Merged
Conversation
…>=3.3 (rapidsai#2283) Closes rapidsai#2282 Remove the `rmm::detail::polyfill` namespace and delete `rmm/detail/cuda_memory_resource.hpp`. All usages are replaced with the CCCL concepts directly (`cuda::mr::synchronous_resource`, `cuda::mr::resource`, etc.). The CCCL version check is relocated to `rmm/detail/export.hpp` and updated to require CCCL >=3.3. (xref: rapidsai/rapids-cmake#981 -- also note that the CCCL 3.3 pre-release was the same as the final release) Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Rong Ou (https://github.com/rongou) URL: rapidsai#2283
…sai#2284) Follow-up to rapidsai#2273. The binning memory resource test recreates a `BinningMemoryResource` (with `FixedSizeMemoryResource` bins backed by `ManagedMemoryResource`) for every `(dtype, nelem, alloc, upstream_mr)` combination. The managed memory slab allocations make each creation take ~0.5–0.9s, totaling ~40s for 147 tests. Restructure the test into a class with a class-scoped fixture so that each `BinningMemoryResource` is built once per `upstream_mr` rather than once per test. A function-scoped autouse fixture sets the current device resource before each test. Times measured on an RTX 2070 Super (8 GiB) under WSL2, where managed memory operations can be particularly expensive. Binning tests drop from ~39s to ~3s; full suite drops from ~49s to ~11s. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Matthew Murray (https://github.com/Matt711) URL: rapidsai#2284
bdice
added
non-breaking
bdice
force-pushed
the
staging-merge-main
branch
from
3ba3725 to
f103d99
Compare
wence-
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This merges the following changes into the
stagingbranch:Checklist