Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on rapids-logger in host to prevent redistribution #1834

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Depend on rapids-logger in host to prevent redistribution #1834

merged 1 commit into from
Feb 24, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 23, 2025

Description

Fixes redistribution of rapids-logger code which can cause clobbering. See #1833.

After this change, the following paths should not be in the librmm package:

  • lib/librapids_logger.so
  • lib/cmake/rapids_logger/*
  • include/rapids_logger/*

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner February 23, 2025 00:33
@bdice bdice requested a review from KyleFromNVIDIA February 23, 2025 00:33
@bdice bdice mentioned this pull request Feb 23, 2025
Open
@github-actions github-actions bot added the conda label Feb 23, 2025
@bdice bdice requested review from vyasr and gforsyth February 23, 2025 00:33
@jakirkham jakirkham added bug Something isn't working non-breaking Non-breaking change labels Feb 24, 2025
@gforsyth
Copy link
Contributor

I pulled down the librmm packages built in the conda-cpp-build job and confirmed they don't include any of the rapids_logger files:

🐚 cph list librmm-25.4.0a29-cuda12_250223_21110050.conda | grep -c rapids_logger
0

@bdice
Copy link
Contributor Author

bdice commented Feb 24, 2025

/merge

@rapids-bot rapids-bot bot merged commit 3f674e3 into rapidsai:branch-25.04 Feb 24, 2025
64 checks passed
VenkateshJaya pushed a commit to VenkateshJaya/rmm that referenced this pull request Mar 10, 2025
@bdice @VenkateshJaya
Depend on rapids-logger in host to prevent redistribution (rapidsai#1834
c19d352 
)

Fixes redistribution of `rapids-logger` code which can cause clobbering. See rapidsai#1833.

After this change, the following paths should _not_ be in the `librmm` package:
- `lib/librapids_logger.so`
- `lib/cmake/rapids_logger/*`
- `include/rapids_logger/*`

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - https://github.com/jakirkham
  - Gil Forsyth (https://github.com/gforsyth)

URL: rapidsai#1834
VenkateshJaya pushed a commit to VenkateshJaya/rmm that referenced this pull request Mar 10, 2025
@bdice @VenkateshJaya
Depend on rapids-logger in host to prevent redistribution (rapidsai#1834
3496cb7 
)

Fixes redistribution of `rapids-logger` code which can cause clobbering. See rapidsai#1833.

After this change, the following paths should _not_ be in the `librmm` package:
- `lib/librapids_logger.so`
- `lib/cmake/rapids_logger/*`
- `include/rapids_logger/*`

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - https://github.com/jakirkham
  - Gil Forsyth (https://github.com/gforsyth)

URL: rapidsai#1834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@gforsyth gforsyth gforsyth approved these changes

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA is a code owner automatically assigned from rapidsai/packaging-codeowners

@vyasr vyasr Awaiting requested review from vyasr

Assignees
No one assigned
Labels
bug Something isn't working conda non-breaking Non-breaking change
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @gforsyth @jakirkham