Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and test with CUDA 12.8.0 #1797

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Build and test with CUDA 12.8.0 #1797

merged 1 commit into from
Jan 28, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 28, 2025

This PR uses CUDA 12.8.0 to build and test.

xref: rapidsai/build-planning#139

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 28, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 28, 2025
@github-actions github-actions bot added the conda label Jan 28, 2025
@bdice
Copy link
Contributor Author

bdice commented Jan 28, 2025

/ok to test

@bdice bdice added the DO NOT MERGE Hold off on merging; see PR for details label Jan 28, 2025
@bdice bdice marked this pull request as ready for review January 28, 2025 15:54
@bdice bdice requested review from a team as code owners January 28, 2025 15:55
@bdice bdice requested a review from msarahan January 28, 2025 15:55
@bdice bdice removed the DO NOT MERGE Hold off on merging; see PR for details label Jan 28, 2025
vyasr
vyasr reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete the 12.5 conda environment? What about 12.5 devcontainers? I could see doing the latter when we also update the devcontainers repo, but the former seems like it should happen in this PR.

.github/workflows/trigger-breaking-change-alert.yaml Show resolved Hide resolved
@bdice
Copy link
Contributor Author

bdice commented Jan 28, 2025

Should we delete the 12.5 conda environment? What about 12.5 devcontainers? I could see doing the latter when we also update the devcontainers repo, but the former seems like it should happen in this PR.

Yes, I did that already in all CUDA 12.8 PRs. See #1797 (comment).

@bdice
Copy link
Contributor Author

bdice commented Jan 28, 2025

/merge

@rapids-bot rapids-bot bot merged commit 401483c into rapidsai:branch-25.02 Jan 28, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @vyasr