Add support for Python 3.14#881
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
gforsyth
added
non-breaking
|
/ok to test |
|
Looks like |
|
/ok to test |
|
/ok to test |
1 similar comment
|
/ok to test |
| # https://github.com/python/cpython/issues/126831 | ||
| multiprocessing.set_start_method("fork") | ||
|
|
There was a problem hiding this comment.
This is another place where the change to forkserver as the default method is causing issues.
This is the simple workaround which I've put in place just to get things passing.
| py: "3.14" | ||
| packages: | ||
| - matrix: | ||
| arch: x86_64 | ||
| py: "3.*" | ||
| packages: | ||
| - ray-default>=2.49,<2.52 | ||
| - matrix: | ||
| arch: aarch64 | ||
| packages: | ||
|
|
||
| - matrix: | ||
| packages: |
There was a problem hiding this comment.
This can be reverted once ray-default supports Python 3.14
There was a problem hiding this comment.
Could you open an issue in the repo tracking that and put a TODO comment here linking to it? That'll make it less likely to be forgotten.
details for that issue:
rayitself doesn't have Python 3.14 wheels yet, tracked here: Support Python 3.14 ray-project/ray#56434- even if it did, it couldn't have conda packages yet because its dependencies aren't supporting Python 3.14 (from https://conda-forge.org/status/migration/?name=python314)
|
/ok to test |
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
One small suggestion, otherwise looks good to me. If ray is an optional dependency of this project then I agree shipping with partial 3.14 support is better than waiting for ray.
| py: "3.14" | ||
| packages: | ||
| - matrix: | ||
| arch: x86_64 | ||
| py: "3.*" | ||
| packages: | ||
| - ray-default>=2.49,<2.52 | ||
| - matrix: | ||
| arch: aarch64 | ||
| packages: | ||
|
|
||
| - matrix: | ||
| packages: |
There was a problem hiding this comment.
Could you open an issue in the repo tracking that and put a TODO comment here linking to it? That'll make it less likely to be forgotten.
details for that issue:
rayitself doesn't have Python 3.14 wheels yet, tracked here: Support Python 3.14 ray-project/ray#56434- even if it did, it couldn't have conda packages yet because its dependencies aren't supporting Python 3.14 (from https://conda-forge.org/status/migration/?name=python314)
|
/merge |
3 participants
Description
Contributes to rapidsai/build-planning#205
This PR adds support for Python 3.14.
Notes for Reviewers
This is part of ongoing work to add Python 3.14 support across RAPIDS.
It temporarily introduces a build/test matrix including Python 3.14, from rapidsai/shared-workflows#508.
A follow-up PR will revert back to pointing at the
mainbranch ofshared-workflowsonce allRAPIDS repos have added Python 3.14 support.
This will fail until all dependencies have been updated to Python 3.14
CI here is expected to fail until all of this project's upstream dependencies support Python 3.14.
This can be merged whenever all CI jobs are passing.