build: remove stale NVCC -diag-suppress=1407 - #1100
Merged
rapids-bot[bot] merged 1 commit intoJun 15, 2026
Merged
Conversation
The suppression was added 2 years ago to silence an NVCC warning about visibility attributes on CCCL template instantiations with internal linkage (e.g. in anonymous namespaces). This has since been fixed in CCCL and the warning no longer fires with current toolchains. Verified by compiling the only .cu file in the repo (cpp/tests/test_allreduce.cu) with -Werror=all-warnings and no suppression — zero warning 1407 instances are emitted. Closes NVIDIA/cudf#22771 (partial — this addresses the rapidsmpf follow-up item referenced from PR rapidsai#1083). Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
vyasr
added
improvement
10 tasks
madsbk
approved these changes
Jun 15, 2026
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
-diag-suppress=1407NVCC flag fromcmake/Modules/ConfigureCUDA.cmake.Background
The suppression was added in the initial commit ~2 years ago to silence NVCC warning 1407, which fires when CCCL templates are instantiated in contexts with internal linkage (e.g. anonymous namespaces). The comment noted: "This is not a problem and will be fixed in future versions of CCCL."
The item was tracked as a follow-up in rapidsai/cudf#22771, referenced from PR #1083 discussion.
Why it's safe to remove
.cufiles — all source undercpp/src/is.cpp, so the NVCC-specific flag never applied to library compilation..cufile iscpp/tests/test_allreduce.cu, which uses CCCL templates (cuda::std::plus,cuda::minimum, etc.) inside an anonymous namespace — exactly the pattern that used to trigger the warning.test_allreduce.cuwith-Werror=all-warningsand without-diag-suppress=1407using CUDA 12.9 (nvcc V12.9.86) produces zero warning 1407 instances. CCCL has fixed the underlying visibility attribute issue.Addresses