-
Notifications
You must be signed in to change notification settings - Fork 38
Remove cudf components #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cudf components #1083
Changes from all commits
698149d
f4908d9
8ed93f8
66bb33c
a64bfa3
0b7e80a
24539a3
dabc851
dc41604
11eb473
4dc1c40
b989a5b
a6a6041
29d8849
c2a3473
f2567e0
fc78969
ce4fd98
3657e5e
1396c3d
67733e0
0c6c989
3c541ac
9e4e098
f93f06d
6c54c92
da4a4da
b5c84f6
d120f5d
7e5d658
bd34e91
c6d9a04
46d3af6
42562a3
a397198
6022ab7
dd9d025
f509d62
85e4ae9
21ee1b6
8879441
c925c61
1b4ee3c
e644a81
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # ================================================================================= | ||
| # cmake-format: off | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # cmake-format: on | ||
| # ================================================================================= | ||
|
|
||
| # This function finds cudf_streaming for test/benchmark use only. It does NOT add cudf_streaming to | ||
| # any rapidsmpf export set. | ||
| function(find_and_configure_cudf_streaming) | ||
|
|
||
| if(TARGET cudf_streaming::cudf_streaming) | ||
| return() | ||
| endif() | ||
|
|
||
| set(oneValueArgs VERSION GIT_REPO GIT_TAG) | ||
| cmake_parse_arguments(PKG "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN}) | ||
|
|
||
| rapids_cpm_find( | ||
| cudf_streaming ${PKG_VERSION} | ||
| GLOBAL_TARGETS cudf_streaming::cudf_streaming | ||
| CPM_ARGS | ||
| GIT_REPOSITORY ${PKG_GIT_REPO} | ||
| GIT_TAG ${PKG_GIT_TAG} | ||
| GIT_SHALLOW TRUE SOURCE_SUBDIR cpp/libcudf_streaming | ||
| OPTIONS "BUILD_TESTS OFF" "BUILD_BENCHMARKS OFF" "BUILD_EXAMPLES OFF" | ||
| ) | ||
| endfunction() | ||
|
|
||
| find_and_configure_cudf_streaming( | ||
| VERSION ${RAPIDS_VERSION} GIT_REPO https://github.com/rapidsai/cudf.git GIT_TAG | ||
| "${RAPIDS_BRANCH}" | ||
| ) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ cache: | |
| export CXXFLAGS=$(echo $CXXFLAGS | sed -E 's@\-fdebug\-prefix\-map[^ ]*@@g') | ||
| set +x | ||
|
|
||
| ./build.sh -v -n --cmake-args=\"-DBUILD_CUPTI_SUPPORT=ON\" --no-clang-tidy librapidsmpf | ||
| ./build.sh -v -n --cmake-args="\"-DBUILD_CUPTI_SUPPORT=ON -DBUILD_CUDF_TESTS=ON\"" --no-clang-tidy librapidsmpf | ||
| secrets: | ||
| - AWS_ACCESS_KEY_ID | ||
| - AWS_SECRET_ACCESS_KEY | ||
|
|
@@ -77,8 +77,9 @@ cache: | |
| - cuda-version =${{ cuda_version }} | ||
| - cuda-cupti-dev | ||
| - cuda-nvml-dev | ||
| - libcudf =${{ minor_version }} | ||
| - libnuma | ||
| - libcudf =${{ minor_version }} | ||
| - libcudf-streaming =${{ minor_version }} | ||
| - libpmix-devel >=5.0,<6.0 | ||
| - librmm =${{ minor_version }} | ||
| - libucxx ${{ ucxx_version }} | ||
|
|
@@ -92,7 +93,6 @@ outputs: | |
| script: | ||
| content: | | ||
| cmake --install cpp/build | ||
| cmake --install cpp/build --component=benchmarking | ||
| cmake --install cpp/build --component=tools | ||
| dynamic_linking: | ||
| overlinking_behavior: "error" | ||
|
|
@@ -102,7 +102,6 @@ outputs: | |
| ignore: | ||
| # See https://github.com/rapidsai/build-planning/issues/160 | ||
| - lib/librapidsmpf.so | ||
| - lib/librapidsmpfndsh.so | ||
| string: cuda${{ cuda_major }}_${{ date_string }}_${{ head_rev }} | ||
| requirements: | ||
| build: | ||
|
|
@@ -114,15 +113,14 @@ outputs: | |
| - cuda-version =${{ cuda_version }} | ||
| - cuda-cupti-dev | ||
| - cuda-nvml-dev | ||
| - libcudf =${{ minor_version }} | ||
| - libpmix-devel >=5.0,<6.0 | ||
| - libucxx ${{ ucxx_version }} | ||
| - openmpi >=5.0 | ||
| - libnuma | ||
| run: | ||
| - ${{ pin_compatible("cuda-version", upper_bound="x", lower_bound="x") }} | ||
| - cuda-cupti | ||
| - librmm =${{ minor_version }} | ||
| - libcudf =${{ minor_version }} | ||
| - libpmix >=5.0,<6.0 | ||
| - libucxx ${{ ucxx_version }} | ||
| - openmpi >=5.0 # See <https://github.com/rapidsai/rapidsmpf/issues/17> | ||
|
|
@@ -135,8 +133,9 @@ outputs: | |
| by_name: | ||
| - cuda-cupti | ||
| - libcudf | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We still need to ignore Only the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch. |
||
| - openmpi | ||
| - libcudf-streaming | ||
| - librmm | ||
| - openmpi | ||
| about: | ||
| homepage: https://github.com/rapidsai/rapidsmpf | ||
| license: Apache-2.0 | ||
|
|
@@ -148,7 +147,8 @@ outputs: | |
| build: | ||
| script: | ||
| content: | | ||
| cmake --install cpp/build --component testing | ||
| cmake --install cpp/build --component=testing | ||
| cmake --install cpp/build --component=benchmarking | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This has an
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed — using |
||
| string: cuda${{ cuda_major }}_${{ date_string }}_${{ head_rev }} | ||
| requirements: | ||
| build: | ||
|
|
@@ -161,14 +161,17 @@ outputs: | |
| - cuda-nvml-dev | ||
| - cuda-version =${{ cuda_version }} | ||
| - libcudf =${{ minor_version }} | ||
| - libcudf-streaming =${{ minor_version }} | ||
| - librmm =${{ minor_version }} | ||
| - openmpi >=5.0 | ||
| - libnuma | ||
| - ${{ pin_subpackage("librapidsmpf", exact=True) }} | ||
| run: | ||
| - ${{ pin_compatible("cuda-version", upper_bound="x", lower_bound="x") }} | ||
| - cuda-cupti | ||
| - librmm =${{ minor_version }} | ||
| - libcudf =${{ minor_version }} | ||
| - libcudf-streaming =${{ minor_version }} | ||
| - librmm =${{ minor_version }} | ||
| - openmpi >=5.0 # See <https://github.com/rapidsai/rapidsmpf/issues/17> | ||
| - libucxx ${{ ucxx_version }} | ||
| ignore_run_exports: | ||
|
|
@@ -180,7 +183,6 @@ outputs: | |
| by_name: | ||
| - cuda-cupti | ||
| - librmm | ||
| - libcudf | ||
| - openmpi | ||
| about: | ||
| homepage: https://github.com/rapidsai/rapidsmpf | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up: This suppression has been here since @madsbk's "initial commit" 2 years ago. We should re-evaluate if it is still needed and remove it if not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this task to NVIDIA/cudf#22771.