Remove custom MemoryAvailable functions - #1061
Merged
rapids-bot[bot] merged 1 commit intoMay 27, 2026
Merged
Conversation
madsbk
added
breaking
wence-
requested changes
May 26, 2026
madsbk
force-pushed
the
remove-memory-availability-functions
branch
3 times, most recently
from
May 26, 2026 18:39
bfe495f to
b69d9cb
Compare
nirandaperera
requested changes
May 26, 2026
madsbk
force-pushed
the
remove-memory-availability-functions
branch
from
May 26, 2026 18:52
b69d9cb to
fccfe1d
Compare
madsbk
force-pushed
the
remove-memory-availability-functions
branch
from
May 26, 2026 19:14
fccfe1d to
8f7590f
Compare
madsbk
marked this pull request as ready for review
May 26, 2026 19:57
wence-
approved these changes
May 27, 2026
nirandaperera
approved these changes
May 27, 2026
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the upcoming work for #641,
RmmResourceAdaptorwill be merged intoBufferResource, which removes most of the motivation for supporting a generic memory-availability callback.This PR simplifies the API to match how it is actually used. Today,
BufferResourceaccepts an arbitrarystd::function<std::int64_t()>perMemoryType, but every real caller simply wrapsLimitAvailableMemory(adaptor, limit), which reduces to a straightforwardlimit - current_allocated()computation.This PR replaces the callback map with a plain integer limit, defaulting to
std::numeric_limits<std::int64_t>::max()to represent "unlimited".To further simplify the API,
BufferResourcenow constructs theRmmResourceAdaptorinternally, so users no longer need to interact withRmmResourceAdaptordirectly.