-
Notifications
You must be signed in to change notification settings - Fork 38
Add OrderScheme.get_boundaries API
#1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e904d2f
basic get_boundaries method in Python
rjzamora 8e58ea3
Merge remote-tracking branch 'upstream/main' into get_boundaries
rjzamora 0b2d41f
Merge remote-tracking branch 'upstream/main' into get_boundaries
rjzamora ba6619d
return single TableChunk instead of tuple[Table, Stream]
rjzamora 2cc76ff
Merge remote-tracking branch 'upstream/main' into get_boundaries
rjzamora 42c8c50
Merge branch 'main' into get_boundaries
rjzamora aae9828
Merge branch 'main' into get_boundaries
rjzamora 3576b55
update docstring
rjzamora 3206991
Merge remote-tracking branch 'upstream/main' into get_boundaries
rjzamora 79023d7
Merge branch 'get_boundaries' of github.com:rjzamora/rapidsmpf into g…
rjzamora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I am looking at this, did the OrderScheme need to keep the
BufferResourcecorresponding to theTableChunkwe created it from alive, I think yes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the buffer resource attached to the context? The context should outlive this metadata I think. Am I misunderstanding the question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I think @wence- was asking what happens if users do not live up to that contract.
I am okay with this PR as-is, since the current contract is that the
BufferResourceoutlives this metadata.That said, I think this highlights a broader design issue we should address separately. We still do not have a clean ownership/lifetime story around
BufferResourcein Python.I think it is time for me to start working on #641 :)