Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure rapids-cmake doesn't produce CMake syntax warnings #80

Conversation

robertmaynard
Copy link
Contributor

Fixes the syntax warning that existed in rapids-cmake/cpm/package_override.cmake. To make sure that other syntax warning don't creep into rapids-cmake we make them errors for all rapids-cmake tests

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team Code quality labels Sep 15, 2021
@robertmaynard robertmaynard force-pushed the correct_syntax_warning_inpackage_override branch from c8eced7 to 6bd9223 Compare September 15, 2021 16:01
@robertmaynard
Copy link
Contributor Author

rerun tests

2 similar comments
@robertmaynard
Copy link
Contributor Author

rerun tests

@robertmaynard
Copy link
Contributor Author

rerun tests

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 54e4614 into rapidsai:branch-21.10 Sep 16, 2021
@robertmaynard robertmaynard deleted the correct_syntax_warning_inpackage_override branch September 16, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Code quality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant