rapids-cmake SHOULD_FAIL tests verify the CMake Error string #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now check the error message output from CMake to make sure we have the expected output on error cases. This makes sure that tests that validate error cases don't fail for other reasons like syntax errors.
robertmaynard
added
feature request
|
@gpucibot merge |
robertmaynard
deleted the
fea/rapids-cmake-failing-tests-verify-cmake-output
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now check the error message output from CMake to make sure we have the expected output on error cases. This makes sure that tests that validate error cases don't fail for other reasons like syntax errors.