rapids-cmake tests no longer download CPM when NO_CPM_CACHE is set.
#682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
KyleFromNVIDIA
requested changes
Aug 21, 2024
Co-authored-by: Kyle Edwards <[email protected]>
Co-authored-by: Kyle Edwards <[email protected]>
KyleFromNVIDIA
approved these changes
Aug 21, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To help reduce the amount of network traffic, rapids-cmake now reuses the same CPM.cmake even when running no CPM cache tests. This elimates one source of network errors as we don't need to fetch the same CPM.cmake multiple times per CI run.
Checklist