Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass GLOBAL_TARGETS to rapids_cpm_find() in rapids_cpm_bs_thread_pool() #655

Merged

Conversation

KyleFromNVIDIA
Copy link
Contributor

Because the GLOBAL_TARGETS option was not being passed, rapids_cpm_bs_thread_pool() was accidentally calling CPMAddPackage() twice for bs_thread_pool, resulting in invalid pinned versions output. Pass GLOBAL_TARGETS to ensure CPMAddPackage() is only called once.

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

Because the GLOBAL_TARGETS option was not being passed,
rapids_cpm_bs_thread_pool() was accidentally calling CPMAddPackage()
twice for bs_thread_pool, resulting in invalid pinned versions output.
Pass GLOBAL_TARGETS to ensure CPMAddPackage() is only called once.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner July 24, 2024 17:59
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change labels Jul 24, 2024
@KyleFromNVIDIA KyleFromNVIDIA added the 3 - Ready for Review Ready for review by team label Jul 24, 2024
@robertmaynard robertmaynard added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jul 24, 2024
@robertmaynard
Copy link
Contributor

/merge

@raydouglass raydouglass merged commit 1dbd2a9 into rapidsai:branch-24.08 Jul 24, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants