Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all rapids-cmake files have include guards #63

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Ensure that all rapids-cmake files have include guards #63

merged 1 commit into from
Aug 11, 2021

Conversation

robertmaynard
Copy link
Contributor

This brings all of rapids/export inline with rapids-cmake code requirement which requires that all modules to use include_guard(GLOBAL).

@robertmaynard robertmaynard added improvement Improves an existing functionality non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Aug 10, 2021
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 357c104 into rapidsai:branch-21.10 Aug 11, 2021
@robertmaynard robertmaynard deleted the bug/ensure_all_modules_have_include_guards branch August 11, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robertmaynard