Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only output CUDA architectures we are building for once #621

Conversation

robertmaynard
Copy link
Contributor

Description

When multiple projects inside the root level all use rapids-cmake we would previously output the CUDA architectures which would all have the same values.

Checklist

  • I am familiar with the Contributing Guidelines.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels May 23, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner May 23, 2024 21:01
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 41dc962 into rapidsai:branch-24.06 May 24, 2024
15 checks passed
@robertmaynard robertmaynard deleted the fea/set_architectures_only_for_root_project branch May 24, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants