Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump NVBench version for new main hooks. #584

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Bump NVBench version for new main hooks. #584

merged 1 commit into from
Apr 24, 2024

Conversation

alliepiper
Copy link
Contributor

Description

Updates nvbench for rapidsai/cudf#15492

Checklist

  • I am familiar with the Contributing Guidelines.
  • [N/a] New or existing tests cover these changes.
  • [N/a] The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change labels Apr 17, 2024
@robertmaynard
Copy link
Contributor

Once cudf has merged https://github.com/rapidsai/cudf/pull/15492 we are good to merge this. If we merged this ahead of time cudf benchmarks will break as the existing patch fails to apply

@robertmaynard robertmaynard mentioned this pull request Apr 17, 2024
Merged
@robertmaynard
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit e1fbcd9 into rapidsai:branch-24.06 Apr 24, 2024
15 checks passed
@alliepiper alliepiper mentioned this pull request May 1, 2024
Merged
1 task
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request May 2, 2024
@alliepiper
Remove NVBench SHA override. (#15633)
8cc4cc1 
The override is no longer necessary as rapids-cmake now uses the same version that was set by the override.

Refs rapidsai/rapids-cmake#584, #15492

Authors:
  - Allison Piper (https://github.com/alliepiper)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Bradley Dice (https://github.com/bdice)

URL: #15633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alliepiper @robertmaynard