rapids_cpm_package_details now validates required entries exist #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
robertmaynard
force-pushed
the
fea/cpm_error_messages_on_bad_json_entries
branch
from
db7d77f
to
76d37ee
Compare
rapids-cmake now provides proper error message reports when the required json entry fields don't exist in either the root `versions.json` or the package override.
robertmaynard
force-pushed
the
fea/cpm_error_messages_on_bad_json_entries
branch
from
76d37ee
to
e5cb4b2
Compare
bdice
approved these changes
Mar 13, 2024
bdice
reviewed
Mar 13, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rapids-cmake now provides proper error message reports when the required json entry fields don't exist in either the root
versions.jsonor the package override.Checklist
cmake-format.jsonis up to date with these changes.