Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to nvcomp 3.0.6. #542

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 23, 2024

Description

Move to nvcomp 3.0.6. Needed for a hotfix for rapidsai/cudf#15096.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@jakirkham
Copy link
Member

Looks like we are seeing an error on CI:

Traceback (most recent call last):
  File "/opt/conda/bin/rapids-dependency-file-generator", line 8, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.10/site-packages/rapids_dependency_file_generator/cli.py", line 126, in main
    make_dependency_files(parsed_config, args.config, to_stdout)
  File "/opt/conda/lib/python3.10/site-packages/rapids_dependency_file_generator/rapids_dependency_file_generator.py", line 429, in make_dependency_files
    raise ValueError(
ValueError: No matching matrix found in 'build' for: {'cuda': '12.2', 'arch': 'x86_64', 'py': '3.10'}

@bdice
Copy link
Contributor Author

bdice commented Feb 23, 2024

Ouch. We updated the CI images latest tag to use CUDA 12.2. It uses the latest image for this job, which uses CUDA 12.2 to generate the style check environment (

--matrix "cuda=${RAPIDS_CUDA_VERSION%.*};arch=$(arch);py=${RAPIDS_PY_VERSION}" | tee env.yaml
). We probably need to revert a PR I made recently. Reverting here: rapidsai/ci-imgs#114

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bump looks fine. Feel free to merge once upstream CI issues are addressed.

@jakirkham
Copy link
Member

Going to close/reopen to refresh the PR CI given the reversion since landed

@jakirkham jakirkham closed this Feb 24, 2024
@jakirkham jakirkham reopened this Feb 24, 2024
@jakirkham jakirkham added bug Something isn't working non-breaking Introduces a non-breaking change labels Feb 24, 2024
@jakirkham
Copy link
Member

Alright style check is now cleared up. Thanks Bradley and Vyas! 🙏

Let's see how the rest of the builds do

@jakirkham
Copy link
Member

Seeing a couple of jobs with test failures. Don't think they are related to nvCOMP. Though interesting to see the failures nevertheless. These are all of the tests that failed between two jobs

	688 - cpm_find-version-explicit-install-makefile (Failed)
	736 - cpm_cccl-export-makefile (Failed)
	743 - cpm_cccl-preserve-custom-install-loc-ninja_multi-config_configure (Failed)
	744 - cpm_cccl-preserve-custom-install-loc-ninja_multi-config (Not Run)
	814 - cpm_nvbench-conda-fmt-makefile_configure (Failed)
	815 - cpm_nvbench-conda-fmt-makefile (Not Run)
	870 - cpm_thrust-export-ninja_multi-config (Failed)
	878 - cpm_thrust-verify-post-find-code-ninja_multi-config_configure (Failed)
	879 - cpm_thrust-verify-post-find-code-ninja_multi-config (Not Run)

@raydouglass raydouglass merged commit bf3faf0 into rapidsai:branch-24.02 Feb 26, 2024
24 of 26 checks passed
raydouglass pushed a commit to rapidsai/kvikio that referenced this pull request Feb 26, 2024
This PR bumps nvcomp to 3.0.6. This is needed as a hotfix for rapidsai/cudf#15096.

Depends on:
- conda-forge/nvcomp-feedstock#14
- rapidsai/rapids-cmake#542

Authors:
   - Bradley Dice (https://github.com/bdice)

Approvers:
   - Ray Douglass (https://github.com/raydouglass)
raydouglass pushed a commit to rapidsai/cudf that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants