Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support static builds of gbench and nvbench. #481

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Support static builds of gbench and nvbench. #481

merged 2 commits into from
Nov 13, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

Support explicit requests for STATIC builds of nvbench and gbench.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change labels Nov 2, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner November 2, 2023 20:07
@robertmaynard robertmaynard force-pushed the fea/support_static_nvbench_and_gbench branch 2 times, most recently from 06860ad to 96a42aa Compare November 2, 2023 20:11
@robertmaynard
Support static builds of gbench and nvbench.
36bc687 
Since we updated nvbench, we also support installing nvbench.
@robertmaynard robertmaynard force-pushed the fea/support_static_nvbench_and_gbench branch from 96a42aa to 36bc687 Compare November 2, 2023 20:21
bdice
bdice approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine to me.

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b18562b into rapidsai:branch-23.12 Nov 13, 2023
16 checks passed
@robertmaynard robertmaynard deleted the fea/support_static_nvbench_and_gbench branch November 13, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @bdice