Introduce RAPIDS.cmake a better way to fetch rapids-cmake #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
improvement
ajschmidt8
approved these changes
Jul 20, 2021
|
rerun tests |
The original approach of using FetchContent naively to acquire
rapids-cmake has a subtle bug, which can easily be resolved
by using the new and improved RAPIDS.cmake approach.
Now to acquire rapids-cmake projects can do the following:
```cmake
file(DOWNLOAD
https://github.com/rapidsai/rapids-cmake/blob/branch-<Major>.<Minor>/RAPIDS.cmake
${CMAKE_BINARY_DIR})
include(${CMAKE_BINARY_DIR}/RAPIDS.cmake)
```
This will automatically fetch rapids-cmake if that hasn't happened
before. Otherwise unlike the old approach it will ensure that
rapids-cmake is in CMAKE_MODULE_PATH, solving a subtle bug.
When multiple adjacent projects included rapids-cmake via CPM they
would hit a bug where the second project couldn't find any rapids-cmake
modules.
robertmaynard
force-pushed
the
fea/introduce_rapids.cmake
branch
from
5fecc96
to
2829694
Compare
|
rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original approach of using FetchContent naively to acquire
rapids-cmake has a subtle bug, which can easily be resolved
by using the new and improved RAPIDS.cmake approach.
Now to acquire rapids-cmake projects can do the following:
This will automatically fetch rapids-cmake if that hasn't happened
before. Otherwise unlike the old approach it will ensure that
rapids-cmake is in CMAKE_MODULE_PATH, solving a subtle bug.
When multiple adjacent projects included rapids-cmake via CPM they
would hit a bug where the second project couldn't find any rapids-cmake
modules.