Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rapids-cmake ci to support conda-forge CUDA 12 #437

Merged
merged 12 commits into from
Jul 13, 2023
Merged

Update rapids-cmake ci to support conda-forge CUDA 12 #437

merged 12 commits into from
Jul 13, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

Needed due to the changes coming to the rapids shared-action-workflow: rapidsai/shared-workflows#112

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change labels Jul 12, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner July 12, 2023 19:53
@robertmaynard robertmaynard requested a review from bdice July 12, 2023 20:14
bdice
bdice reviewed Jul 12, 2023
View reviewed changes
conda/recipes/rapids_core_dependencies/meta.yaml Show resolved Hide resolved
dependencies.yaml Show resolved Hide resolved
ci/check_style.sh Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor

bdice commented Jul 12, 2023

For CUDA 12, we need to either add the flag -DNVBench_ENABLE_CUPTI=OFF to the tests that use nvbench, or add the package cuda-cupti-dev to the conda environment for tests (in dependencies.yaml).

bdice
bdice approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me!

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 05be912 into rapidsai:branch-23.08 Jul 13, 2023
13 checks passed
@robertmaynard robertmaynard deleted the fea/use_cuda-120_ci_workflow branch July 13, 2023 13:38
@bdice bdice mentioned this pull request Jul 13, 2023
Closed
17 tasks
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@bdice bdice bdice approved these changes

Assignees

@robertmaynard robertmaynard

Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertmaynard @bdice @jakirkham @raydouglass