Bump cuco version #435
Merged
Bump cuco version #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dantegd
reviewed
Jul 7, 2023
There was a problem hiding this comment.
@PointKernel Wouldn't this require PRs in other repos besides cuDF to check it doesn't break projects like RAFT or cuML? Not sure how significant the bump is
@dantegd Valid concern. I had a quick look at other RAPIDS repos and found To address your concern, I tried to put up a PR testing the new cuco in rapids_cpm_find(
cuco 0.0.1
GLOBAL_TARGETS cuco::cuco
CPM_ARGS
GIT_REPOSITORY https://github.com/NVIDIA/cuCollections.git
GIT_TAG 303f134573afa315cf14fca3f7a0b730438497c3
OPTIONS "BUILD_TESTS OFF" "BUILD_BENCHMARKS OFF" "BUILD_EXAMPLES OFF"
)but then got CMake errors: -- CPM: adding package [email protected] (303f134573afa315cf14fca3f7a0b730438497c3)
-- Auto detection of gpu-archs: 75
-- CPM: cuco: adding package [email protected] (branch/1.9.1)
-- rapids-cmake [libcudacxx]: failed to apply diff install_rules.diffrapids-cmake [libcudacxx]: git diff output: error: patch failed: cmake/libcudacxxInstallRules.cmake:1
-- error: cmake/libcudacxxInstallRules.cmake: patch does not apply
-- error: patch failed: lib/cmake/libcudacxx/libcudacxx-header-search.cmake.in:1
-- error: lib/cmake/libcudacxx/libcudacxx-header-search.cmake.in: patch does not apply
--
-- rapids-cmake [libcudacxx]: applied diff reroot_support.diff to fix issue: 'Support conda-forge usage of CMake rerooting [https://github.com/NVIDIA/libcudacxx/pull/490]'
-- CPM: using local package [email protected]
TEST PATH: test/cluster/kmeans.cu;test/cluster/kmeans_balanced.cu;test/cluster/cluster_solvers.cu;test/cluster/linkage.cu;test/cluster/kmeans_find_k.cu
TEST PATH: test/core/logger.cpp;test/core/math_device.cu;test/core/math_host.cpp;test/core/operators_device.cu;test/core/operators_host.cpp;test/core/handle.cpp;test/core/interruptible.cu;test/core/nvtx.cpp;test/core/mdarray.cu;test/core/mdspan_utils.cu;test/core/numpy_serializer.cu;test/core/memory_type.cpp;test/core/sparse_matrix.cu;test/core/sparse_matrix.cpp;test/core/span.cpp;test/core/span.cu;test/core/temporary_device_buffer.cu;test/test.cpp
TEST PATH: test/distance/dist_adj.cu;test/distance/dist_adj_distance_instance.cu;test/distance/dist_canberra.cu;test/distance/dist_correlation.cu;test/distance/dist_cos.cu;test/distance/dist_hamming.cu;test/distance/dist_hellinger.cu;test/distance/dist_inner_product.cu;test/distance/dist_jensen_shannon.cu;test/distance/dist_kl_divergence.cu;test/distance/dist_l1.cu;test/distance/dist_l2_exp.cu;test/distance/dist_l2_unexp.cu;test/distance/dist_l2_sqrt_exp.cu;test/distance/dist_l_inf.cu;test/distance/dist_lp_unexp.cu;test/distance/dist_russell_rao.cu;test/distance/masked_nn.cu;test/distance/masked_nn_compress_to_bits.cu;test/distance/fused_l2_nn.cu;test/distance/gram.cu
TEST PATH: test/ext_headers/raft_neighbors_brute_force.cu;test/ext_headers/raft_distance_distance.cu;test/ext_headers/raft_distance_detail_pairwise_matrix_dispatch.cu;test/ext_headers/raft_matrix_detail_select_k.cu;test/ext_headers/raft_neighbors_ball_cover.cu;test/ext_headers/raft_spatial_knn_detail_fused_l2_knn.cu;test/ext_headers/raft_distance_fused_l2_nn.cu;test/ext_headers/raft_neighbors_ivf_pq.cu;test/ext_headers/raft_util_memory_pool.cpp;test/ext_headers/raft_neighbors_ivf_flat.cu;test/ext_headers/raft_core_logger.cpp;test/ext_headers/raft_neighbors_refine.cu;test/ext_headers/raft_neighbors_detail_ivf_flat_search.cu;test/ext_headers/raft_neighbors_detail_selection_faiss.cu;test/ext_headers/raft_linalg_detail_coalesced_reduction.cu;test/ext_headers/raft_spatial_knn_detail_ball_cover_registers.cu;test/ext_headers/raft_neighbors_detail_ivf_flat_interleaved_scan.cu;test/ext_headers/raft_neighbors_detail_ivf_pq_compute_similarity.cu
TEST PATH: test/ext_headers/raft_neighbors_brute_force.cu;test/ext_headers/raft_distance_distance.cu;test/ext_headers/raft_distance_detail_pairwise_matrix_dispatch.cu;test/ext_headers/raft_matrix_detail_select_k.cu;test/ext_headers/raft_neighbors_ball_cover.cu;test/ext_headers/raft_spatial_knn_detail_fused_l2_knn.cu;test/ext_headers/raft_distance_fused_l2_nn.cu;test/ext_headers/raft_neighbors_ivf_pq.cu;test/ext_headers/raft_util_memory_pool.cpp;test/ext_headers/raft_neighbors_ivf_flat.cu;test/ext_headers/raft_core_logger.cpp;test/ext_headers/raft_neighbors_refine.cu;test/ext_headers/raft_neighbors_detail_ivf_flat_search.cu;test/ext_headers/raft_neighbors_detail_selection_faiss.cu;test/ext_headers/raft_linalg_detail_coalesced_reduction.cu;test/ext_headers/raft_spatial_knn_detail_ball_cover_registers.cu;test/ext_headers/raft_neighbors_detail_ivf_flat_interleaved_scan.cu;test/ext_headers/raft_neighbors_detail_ivf_pq_compute_similarity.cu
TEST PATH: test/ext_headers/raft_neighbors_brute_force.cu;test/ext_headers/raft_distance_distance.cu;test/ext_headers/raft_distance_detail_pairwise_matrix_dispatch.cu;test/ext_headers/raft_matrix_detail_select_k.cu;test/ext_headers/raft_neighbors_ball_cover.cu;test/ext_headers/raft_spatial_knn_detail_fused_l2_knn.cu;test/ext_headers/raft_distance_fused_l2_nn.cu;test/ext_headers/raft_neighbors_ivf_pq.cu;test/ext_headers/raft_util_memory_pool.cpp;test/ext_headers/raft_neighbors_ivf_flat.cu;test/ext_headers/raft_core_logger.cpp;test/ext_headers/raft_neighbors_refine.cu;test/ext_headers/raft_neighbors_detail_ivf_flat_search.cu;test/ext_headers/raft_neighbors_detail_selection_faiss.cu;test/ext_headers/raft_linalg_detail_coalesced_reduction.cu;test/ext_headers/raft_spatial_knn_detail_ball_cover_registers.cu;test/ext_headers/raft_neighbors_detail_ivf_flat_interleaved_scan.cu;test/ext_headers/raft_neighbors_detail_ivf_pq_compute_similarity.cu
TEST PATH: test/label/label.cu;test/label/merge_labels.cu
TEST PATH: test/linalg/add.cu;test/linalg/axpy.cu;test/linalg/binary_op.cu;test/linalg/cholesky_r1.cu;test/linalg/coalesced_reduction.cu;test/linalg/divide.cu;test/linalg/dot.cu;test/linalg/eig.cu;test/linalg/eig_sel.cu;test/linalg/gemm_layout.cu;test/linalg/gemv.cu;test/linalg/map.cu;test/linalg/map_then_reduce.cu;test/linalg/matrix_vector.cu;test/linalg/matrix_vector_op.cu;test/linalg/mean_squared_error.cu;test/linalg/multiply.cu;test/linalg/norm.cu;test/linalg/normalize.cu;test/linalg/power.cu;test/linalg/randomized_svd.cu;test/linalg/reduce.cu;test/linalg/reduce_cols_by_key.cu;test/linalg/reduce_rows_by_key.cu;test/linalg/rsvd.cu;test/linalg/sqrt.cu;test/linalg/strided_reduction.cu;test/linalg/subtract.cu;test/linalg/svd.cu;test/linalg/ternary_op.cu;test/linalg/transpose.cu;test/linalg/unary_op.cu
TEST PATH: test/matrix/argmax.cu;test/matrix/argmin.cu;test/matrix/columnSort.cu;test/matrix/diagonal.cu;test/matrix/gather.cu;test/matrix/eye.cu;test/matrix/linewise_op.cu;test/matrix/math.cu;test/matrix/matrix.cu;test/matrix/norm.cu;test/matrix/reverse.cu;test/matrix/select_k.cu;test/matrix/slice.cu;test/matrix/triangular.cu;test/sparse/spectral_matrix.cu
TEST PATH: test/random/make_blobs.cu;test/random/make_regression.cu;test/random/multi_variable_gaussian.cu;test/random/permute.cu;test/random/rng.cu;test/random/rng_discrete.cu;test/random/rng_int.cu;test/random/rmat_rectangular_generator.cu;test/random/sample_without_replacement.cu
TEST PATH: test/cluster/cluster_solvers_deprecated.cu;test/linalg/eigen_solvers.cu;test/lap/lap.cu;test/sparse/mst.cu
TEST PATH: test/sparse/add.cu;test/sparse/convert_coo.cu;test/sparse/convert_csr.cu;test/sparse/csr_row_slice.cu;test/sparse/csr_to_dense.cu;test/sparse/csr_transpose.cu;test/sparse/degree.cu;test/sparse/filter.cu;test/sparse/norm.cu;test/sparse/normalize.cu;test/sparse/reduce.cu;test/sparse/row_op.cu;test/sparse/sort.cu;test/sparse/spgemmi.cu;test/sparse/symmetrize.cu
TEST PATH: test/sparse/dist_coo_spmv.cu;test/sparse/distance.cu;test/sparse/gram.cu
TEST PATH: test/sparse/neighbors/connect_components.cu;test/sparse/neighbors/brute_force.cu;test/sparse/neighbors/knn_graph.cu
TEST PATH: test/neighbors/ann_cagra/test_float_uint32_t.cu;test/neighbors/ann_cagra/test_int8_t_uint32_t.cu;test/neighbors/ann_cagra/test_uint8_t_uint32_t.cu;test/neighbors/ann_cagra/test_float_int64_t.cu;test/neighbors/ann_ivf_flat/test_float_int64_t.cu;test/neighbors/ann_ivf_flat/test_int8_t_int64_t.cu;test/neighbors/ann_ivf_flat/test_uint8_t_int64_t.cu;test/neighbors/ann_ivf_pq/test_float_int64_t.cu;test/neighbors/ann_ivf_pq/test_float_uint32_t.cu;test/neighbors/ann_ivf_pq/test_float_int64_t.cu;test/neighbors/ann_ivf_pq/test_int8_t_int64_t.cu;test/neighbors/ann_ivf_pq/test_uint8_t_int64_t.cu;test/neighbors/knn.cu;test/neighbors/fused_l2_knn.cu;test/neighbors/tiled_knn.cu;test/neighbors/haversine.cu;test/neighbors/ball_cover.cu;test/neighbors/epsilon_neighborhood.cu;test/neighbors/refine.cu;test/neighbors/selection.cu
TEST PATH: test/stats/accuracy.cu;test/stats/adjusted_rand_index.cu;test/stats/completeness_score.cu;test/stats/contingencyMatrix.cu;test/stats/cov.cu;test/stats/dispersion.cu;test/stats/entropy.cu;test/stats/histogram.cu;test/stats/homogeneity_score.cu;test/stats/information_criterion.cu;test/stats/kl_divergence.cu;test/stats/mean.cu;test/stats/meanvar.cu;test/stats/mean_center.cu;test/stats/minmax.cu;test/stats/mutual_info_score.cu;test/stats/r2_score.cu;test/stats/rand_index.cu;test/stats/regression_metrics.cu;test/stats/silhouette_score.cu;test/stats/stddev.cu;test/stats/sum.cu;test/stats/trustworthiness.cu;test/stats/weighted_mean.cu;test/stats/v_measure.cu
TEST PATH: test/core/seive.cu;test/util/bitonic_sort.cu;test/util/cudart_utils.cpp;test/util/device_atomics.cu;test/util/integer_utils.cpp;test/util/pow2_utils.cu;test/util/reduction.cu
-- Configuring done (3.3s)
CMake Error: install(EXPORT "raft-exports" ...) includes target "raft" which requires target "cuco" that is not in any export set.
-- Generating done (0.1s)
CMake Generate step failed. Build files cannot be regenerated correctly.
####################
# Building libraft #
####################
ninja: error: loading 'build.ninja': No such file or directory
real 0m0.064s
user 0m0.033s
sys 0m0.037sAny advice on how to resolve this issue? |
|
@dantegd all tests passed in |
robertmaynard
added
feature request
So did you find a solution to this cmake export error? |
yes, @dantegd pointed me to a similar PR and I got rapidsai/raft#1641 work. |
robertmaynard
approved these changes
Jul 10, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bump the cuco version to the latest.
Opened rapidsai/cudf#13665 to verify it won't break cudf.
Opened rapidsai/raft#1641 to verify it won't break raft.
rapidsai/cugraph#3692 to be addressed once this PR is merged.
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))