Bug/proprietary binary obeys always_download
#430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the fact that `rapids_find_package` is a macro it removes any variable it possible sets during usage. The variable names it unsets are shared with `rapids_cpm_` calls. In cases when `rapids_find_package` is called from `rapids_cpm*` it could overwrite or unset variable defined but `rapids_cpm*` causing weird rapids-cmake failures. To avoid this we make sure that `rapdids_find_package` only constructs unique variable names
robertmaynard
added
breaking
robertmaynard
changed the title
always_download
robertmaynard
force-pushed
the
bug/proprietary_binary_obey_always_download
branch
from
ad1be25
to
87b688f
Compare
robertmaynard
added
bug
vyasr
approved these changes
Jun 22, 2023
|
/merge |
|
@robertmaynard @vyasr Thanks for seeing this through! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update rapids_cpm_nvcomp to check for a local version before downloading the properitary version
Checklist
cmake-format.jsonis up to date with these changes.