Fea/move to latest nvbench #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
robertmaynard
force-pushed
the
fea/move_to_latest_nvbench
branch
from
06c9cdf
to
3aa1750
Compare
bdice
reviewed
May 31, 2023
bdice
approved these changes
May 31, 2023
| rapids_cpm_init() | ||
| rapids_cpm_nvbench() | ||
|
|
||
| file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/use_fmt.cpp" [=[ |
There was a problem hiding this comment.
Is this a minimal repro, or can it be smaller?
There was a problem hiding this comment.
This is about the smallest we can make the repro. It needs to do linking so that we verify that the changes dropped nvbench/public_fmt_dep_in_conda.diff aren't lost from upstream
Co-authored-by: Bradley Dice <[email protected]>
|
/merge |
robertmaynard
added a commit
to robertmaynard/cudf
that referenced
this pull request
Jun 1, 2023
NVBench has integrated the `public_fmt_dep_in_conda` fixes. So for 23.08 rapids-cmake dropped the patch and moved to newest nvbench rapidsai/rapids-cmake#417
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move to latest version of nvbench which includes a fix for a CMake error when using static fmt with a conda env.
Checklist
cmake-format.jsonis up to date with these changes.