rapids_export version support expanded to handle more use-cases #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
3 - Ready for Review
robertmaynard
force-pushed
the
fea/rapids_export_more_robust_version_support
branch
from
53e7e8d
to
457cd90
Compare
robertmaynard
force-pushed
the
fea/rapids_export_more_robust_version_support
branch
from
457cd90
to
b4d65ea
Compare
|
rerun tests |
The rapids_export command now supports the following features: Explicit version argument option. This allows projects to specify a version when calling `rapids_export` instead of having it inferred from the `project()` call. Disabling of version exporting by passing `VERSION OFF`. This removes the generation of any version related information to allow for projects that don't have API/ABI version matching requirements Projects that only have a MAJOR version number now don't try to match on the exact Major.Minor value but instead on Major only
robertmaynard
force-pushed
the
fea/rapids_export_more_robust_version_support
branch
from
b4d65ea
to
619b270
Compare
ajschmidt8
approved these changes
Jul 20, 2021
robertmaynard
force-pushed
the
fea/rapids_export_more_robust_version_support
branch
from
7d70891
to
619b270
Compare
|
rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rapids_export command now supports the following features:
Explicit version argument option. This allows projects to specify a
version when calling
rapids_exportinstead of having it inferredfrom the
project()call.Disabling of version exporting by passing
VERSION OFF. Thisremoves the generation of any version related information to allow
for projects that don't have API/ABI version matching requirements
Projects that only have a MAJOR version number now don't try
to match on the exact Major.Minor value but instead on Major only