Skip to content

Correct CI failures building examples #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
Aug 20, 2026
Merged

Correct CI failures building examples #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ repos:
exclude: |
(?x)
^[.]github/workflows/|
^examples/pin-dependencies/pins.json|
(^|/)RAPIDS_BRANCH$|
[.](md|rst)$
- repo: https://github.com/shellcheck-py/shellcheck-py
Expand Down
2 changes: 1 addition & 1 deletion examples/offline_build/use_offline_source_cache.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

# This script configures and builds the project entirely offline by pointing
Expand Down
3 changes: 2 additions & 1 deletion testing/examples/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ enable_language(CXX)
if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL
13.3)
add_cmake_build_test(pin-dependencies SOURCE_DIR
${CMAKE_CURRENT_SOURCE_DIR}/../../examples/pin-dependencies NO_CPM_CACHE)
${CMAKE_CURRENT_SOURCE_DIR}/../../examples/pin-dependencies NO_CPM_CACHE
WITH_PRESET with-pins)
endif()
add_cmake_build_test(project-bootstrap SOURCE_DIR
${CMAKE_CURRENT_SOURCE_DIR}/../../examples/project-bootstrap)
Expand Down
7 changes: 5 additions & 2 deletions testing/utils/cmake_test.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# =============================================================================
# cmake-format: off
# SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
# cmake-format: on
# =============================================================================
Expand Down Expand Up @@ -67,7 +67,7 @@ adds a test for each generator:
# rapids-pre-commit-hooks: enable[verify-hardcoded-version]
function(add_cmake_test mode source_or_dir)
set(options SERIAL NO_DEV_ERRORS NO_CPM_CACHE NO_RAPIDS_CMAKE_HOOKS)
set(one_value SHOULD_FAIL SOURCE_DIR EXPECT_MATCH)
set(one_value SHOULD_FAIL SOURCE_DIR EXPECT_MATCH WITH_PRESET)
set(multi_value)
cmake_parse_arguments(RAPIDS_TEST "${options}" "${one_value}" "${multi_value}" ${ARGN})

Expand Down Expand Up @@ -103,6 +103,9 @@ function(add_cmake_test mode source_or_dir)
if(NOT (RAPIDS_TEST_NO_DEV_ERRORS OR RAPIDS_TEST_DISABLE_DEV_ERRORS))
list(APPEND extra_configure_flags "-Werror=dev")
endif()
if(DEFINED RAPIDS_TEST_WITH_PRESET)
list(APPEND extra_configure_flags "--preset=${RAPIDS_TEST_WITH_PRESET}")
endif()
if(DEFINED CPM_SOURCE_CACHE AND NOT RAPIDS_TEST_NO_CPM_CACHE)
list(APPEND extra_configure_flags "-DCPM_SOURCE_CACHE=${CPM_SOURCE_CACHE}")
endif()
Expand Down