Skip to content

Commit

Permalink
refactor CUDA versions in dependencies.yaml (#517)
Browse files Browse the repository at this point in the history
Contributes to rapidsai/build-planning#7.

Proposes splitting the `cuda-version` dependency in `dependencies.yaml` out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

### Benefits of this change

* prevents accidental inclusion of multiple `cuda-version` version in environments
* reduces update effort (via enabling more use of globs like `"12.*"`)
* improves the chance that errors like "`conda` recipe is missing a dependency" are caught in CI

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Jake Awe (https://github.com/AyodeAwe)
  - Bradley Dice (https://github.com/bdice)

URL: #517
  • Loading branch information
jameslamb authored Jan 11, 2024
1 parent f38531d commit d18367a
Showing 1 changed file with 39 additions and 21 deletions.
60 changes: 39 additions & 21 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ files:
output: none
includes:
- build
- cudatoolkit
- cuda
- cuda_version
- docs
- py_version
- test
Expand All @@ -17,7 +18,7 @@ files:
docs:
output: none
includes:
- cudatoolkit
- cuda_version
- docs
channels:
- rapidsai
Expand All @@ -35,6 +36,30 @@ dependencies:
- cxx-compiler
- make
specific:
- output_types: conda
matrices:
- matrix:
cuda: "11.[245]"
packages:
- gcc<11.0.0
- matrix:
cuda: "11.[68]"
packages:
- gcc<12.0.0
- matrix:
cuda: "12.*"
packages:
- gcc<13.0.0
- output_types: conda
matrices:
- matrix:
arch: x86_64
packages:
- sysroot_linux-64==2.17
- matrix:
arch: aarch64
packages:
- sysroot_linux-aarch64==2.17
- output_types: conda
matrices:
- matrix:
Expand Down Expand Up @@ -80,54 +105,47 @@ dependencies:
- matrix:
cuda: "12.0"
packages:
- cuda-version=12.0
- cuda-nvcc
cudatoolkit:
cuda_version:
specific:
- output_types: conda
matrices:
- matrix:
cuda: "11.2"
packages:
- cuda-version=11.2
- cudatoolkit
- gcc<11.0.0
- sysroot_linux-64==2.17
- matrix:
cuda: "11.4"
packages:
- cuda-version=11.4
- cudatoolkit
- gcc<11.0.0
- sysroot_linux-64==2.17
- matrix:
cuda: "11.5"
packages:
- cuda-version=11.5
- cudatoolkit
- gcc<11.0.0
- sysroot_linux-64==2.17
- matrix:
cuda: "11.6"
packages:
- cuda-version=11.6
- cudatoolkit
- gcc<12.0.0
- sysroot_linux-64==2.17
- matrix:
cuda: "11.8"
packages:
- cuda-version=11.8
- cudatoolkit
- gcc<12.0.0
- sysroot_linux-64==2.17
- matrix:
cuda: "12.0"
packages:
- cuda-version=12.0
cuda:
specific:
- output_types: conda
matrices:
- matrix:
cuda: "11.*"
packages:
- cudatoolkit
- matrix:
cuda: "12.*"
packages:
- cuda-cupti-dev
- gcc<13.0.0
- sysroot_linux-64==2.17
docs:
common:
- output_types: [conda]
Expand Down

0 comments on commit d18367a

Please sign in to comment.