Skip to content

Comments

Fix clang-format style errors#425

Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-22.02from
achirkin:fix-clang-format-errors
Dec 17, 2021
Merged

Fix clang-format style errors#425
rapids-bot[bot] merged 6 commits intorapidsai:branch-22.02from
achirkin:fix-clang-format-errors

Conversation

@achirkin
Copy link
Contributor

Looks like a few style errors slipped through in one of the last commits preventing other PR from passing their CI checks. This PR fixes that.

@achirkin achirkin requested review from a team as code owners December 17, 2021 07:19
@github-actions github-actions bot added the cpp label Dec 17, 2021
@achirkin achirkin added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change labels Dec 17, 2021
@MatthiasKohl
Copy link
Contributor

Most likely due to #412 which changes the include order for some files slightly.
I'll add some further suggestions.

achirkin and others added 4 commits December 17, 2021 11:10
Co-authored-by: Matt Joux <matthias.kohl@hotmail.de>
Co-authored-by: Matt Joux <matthias.kohl@hotmail.de>
Co-authored-by: Matt Joux <matthias.kohl@hotmail.de>
Copy link
Contributor

@MatthiasKohl MatthiasKohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the style errors, looks good to me.

@cjnolet
Copy link
Member

cjnolet commented Dec 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c05c1fa into rapidsai:branch-22.02 Dec 17, 2021
@achirkin achirkin deleted the fix-clang-format-errors branch March 31, 2022 06:10
loulankxh pushed a commit to loulankxh/raft that referenced this pull request Oct 14, 2025
Looks like a few style errors slipped through in one of the last commits preventing other PR from passing their CI checks. This PR fixes that.

Authors:
  - Artem M. Chirkin (https://github.com/achirkin)

Approvers:
  - Matt Joux (https://github.com/MatthiasKohl)
  - Tamas Bela Feher (https://github.com/tfeher)

URL: rapidsai#425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants