Add UCXX and NCCL to libraft conda recipe#2636
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from Apr 16, 2025
Merged
Add UCXX and NCCL to libraft conda recipe#2636rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from
libraft conda recipe#2636rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from
Conversation
gforsyth
requested changes
Apr 16, 2025
Contributor
gforsyth
left a comment
There was a problem hiding this comment.
The changes look good overall @divyegala -- there are a few additional changes we need to make to avoid overconstraining outputs, and then some small style changes.
Anything in the cache host dependencies that has a run export is inherited by all the outputs.
Can you add nccl to the ignore_run_exports for the libraft-tests, libraft, and libraft-static outputs?
Member
Author
|
@gforsyth thanks for your review! I incorporated your change requests. Let me know what else this PR needs. |
gforsyth
approved these changes
Apr 16, 2025
Contributor
gforsyth
left a comment
There was a problem hiding this comment.
Looks good to go if CI is green!
bdice
approved these changes
Apr 16, 2025
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libraftrecipe installs thedistributedcomponentraft/conda/recipes/libraft/recipe.yaml
Line 94 in 902ed56
NCCLanducxxas seen hereraft/cpp/CMakeLists.txt
Lines 392 to 406 in 902ed56
cc @gforsyth @bdice