split up CUDA-suffixed dependencies in dependencies.yaml#2388
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-24.08from Jul 25, 2024
jameslamb:suffix-split
Merged
split up CUDA-suffixed dependencies in dependencies.yaml#2388rapids-bot[bot] merged 3 commits intorapidsai:branch-24.08from jameslamb:suffix-split
rapids-bot[bot] merged 3 commits intorapidsai:branch-24.08from
jameslamb:suffix-split
Conversation
jameslamb
added
improvement
jameslamb
changed the title
jameslamb
added
3 - Ready for Review
and removed
2 - In Progress
Member
Author
|
I've updated this based on the suggestions from rapidsai/cudf#16183. Ran the following to check git fetch upstream --tags
ci/release/update-version.sh '24.10.00'
git grep -E '24\.8|24\.08|0\.39'No changes to that script were required. |
vyasr
approved these changes
Jul 24, 2024
bdice
approved these changes
Jul 24, 2024
Member
Author
|
queuing this up to auto-merge whenever that last test job is picked up. I'll check back in a bit to see if anything needs to be manually restarted. |
Member
Author
|
/merge |
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
Contributes to rapidsai/build-planning#31 In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g. `cudf` depending on `rmm`, not `rmm-cu12`. This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in `dependencies.yaml`. For more details, see: * rapidsai/build-planning#31 (comment) * rapidsai/cudf#16183 ## Notes for Reviewers ### Why target 24.08? This is targeting 24.08 because: 1. it should be very low-risk 2. getting these changes into 24.08 prevents the need to carry around patches for every library in DLFW builds using RAPIDS 24.08 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Bradley Dice (https://github.com/bdice) URL: rapidsai#2388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#31
In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g.
cudfdepending onrmm, notrmm-cu12.This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in
dependencies.yaml.For more details, see:
Notes for Reviewers
Why target 24.08?
This is targeting 24.08 because: