feat(instrumentation): generate collector routing - #619
Conversation
6eaca4e to
f5e948a
Compare
📝 WalkthroughWalkthroughThe change adds shared collector event serialization and feature-gated collector sink support. Build options enable generated routing, which deserializes events by entity name and forwards them to matching observers. ChangesCollector sink integration
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: 🟡 Moderate · up to The new collector and instrumentation integrations bypass workspace-managed dependency declarations, which can allow dependency versions and features to drift between crates; update the manifests to use workspace dependencies before merging. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 57.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 8 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Description
Based off feat(store): add schema-based filesystem event loading #520 which needs to get merged first.Add schema-generated routing from collector entity stream names to typed instrumentation observers.
CollectorRouterand implementCollectorSinkfor generated model contexts.quent-events/serdedirectly in the collector client.Testing
pixi run cargo fmt --all -- --checkpixi run cargo test -p quent-instrumentation-buildpixi run cargo check -p quent-instrumentation --features io-collectorpixi run cargo test -p quent-instrumentation --features io-collector --test collector_roundtrippixi run cargo test -p quent-collector-clientpixi run cargo test -p quent-collector -p quent-io-collectorWritten by Codex.