Skip to content

feat(ui): add entity-list API wiring, entity swimlanes 1 - #495

Merged
rapids-bot[bot] merged 3 commits into
rapidsai:mainfrom
johallar:joe/long-entities-gantt-1
Aug 3, 2026
Merged

feat(ui): add entity-list API wiring, entity swimlanes 1#495
rapids-bot[bot] merged 3 commits into
rapidsai:mainfrom
johallar:joe/long-entities-gantt-1

Conversation

@johallar

@johallar johallar commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

Add fetchEntityList to @quent/client, an entityListQueryOptions/useEntityList hook, and re-export the generated EntityList* types from @quent/utils.

Related Issues

#215

Testing

No functional changes

Screenshots

N/A

Add fetchEntityList to @quent/client, an entityListQueryOptions/useEntityList
hook, and re-export the generated EntityList* types from @quent/utils.
@johallar
johallar requested a review from cmatzenbach as a code owner July 30, 2026 17:45
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds entity-list type exports, request shaping, an API function, React Query options, a hook, and public client re-exports.

Changes

Entity list client

Layer / File(s) Summary
Entity list contracts and request shaping
ui/packages/@quent/utils/src/types/index.ts, ui/packages/@quent/client/src/entityList.ts
Entity-list, filtering, sorting, pagination, and time-window types are exported; client parameters are converted into the request payload shape.
Entity fetching and query integration
ui/packages/@quent/client/src/api.ts, ui/packages/@quent/client/src/entityList.ts, ui/packages/@quent/client/src/index.ts
The client posts entity-list requests, configures React Query fetching, exposes useEntityList, and re-exports the new API and query helpers.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • rapidsai/quent#258: Adds the entity-list endpoint and matching request/response types used by this client integration.

Suggested labels: feature request, non-breaking

Suggested reviewers: cmatzenbach

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the entity-list API wiring, but the entity swimlanes reference is not reflected in the listed changes.
Description check ✅ Passed The description covers the main changes, related issue, testing note, and screenshots section, but it does not document specific validation commands.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ui/packages/`@quent/client/src/entityList.ts:
- Around line 1-2: Update the SPDX copyright header at the top of entityList.ts
to include the canonical comma after “2026”, preserving the existing copyright
holder and Apache-2.0 license identifier.
- Line 5: Update buildRequest to use the generated QueryFilter and
OperatorFilter types from `@quent/utils` instead of inline { query_id: string }
and { operator_id: string | null } definitions, and add those symbols to the
existing type import. Keep the request construction behavior unchanged.
- Line 4: Remove keepPreviousData from the entity-list query configuration and
ensure results are rendered only when they match the currently requested query
identity, including queryId, window, operator, and filter. Update the
useQuery/queryOptions flow in entityList.ts so identity changes suppress stale
placeholder data until the new response arrives.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 43f060e0-38f1-4d9e-9871-e447e225bfde

📥 Commits

Reviewing files that changed from the base of the PR and between 7574c05 and 3af362e.

📒 Files selected for processing (4)
  • ui/packages/@quent/client/src/api.ts
  • ui/packages/@quent/client/src/entityList.ts
  • ui/packages/@quent/client/src/index.ts
  • ui/packages/@quent/utils/src/types/index.ts

Comment thread ui/packages/@quent/client/src/entityList.ts Outdated
Comment thread ui/packages/@quent/client/src/entityList.ts Outdated
Comment thread ui/packages/@quent/client/src/entityList.ts Outdated
@johallar johallar changed the title feat(client): add entity-list API wiring feat(ui): add entity-list API wiring Jul 30, 2026
@johallar johallar changed the title feat(ui): add entity-list API wiring feat(ui): add entity-list API wiring, entity swinlames 1 Jul 30, 2026
@johallar johallar changed the title feat(ui): add entity-list API wiring, entity swinlames 1 feat(ui): add entity-list API wiring, entity swimlanes 1 Jul 31, 2026
@johallar

johallar commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit ea60e47 into rapidsai:main Aug 3, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants