Repository navigation
feat(schema): add paths for schema types #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ba1a5ae
feat(schema): add paths for schema types
johanpel 08b60ad
feat(constraints): validate schema type paths
johanpel 405995d
feat(fsm): support entity paths
johanpel ce2dbf5
feat(ref-target): support entity paths
johanpel 1fd5a8f
feat(ref-tree): support entity paths
johanpel 39f6a3f
feat(resource): support resource paths
johanpel bd22bbc
refactor(yaml): lower type names to paths
johanpel 0a3716a
refactor(instrumentation-build): reject qualified type paths
johanpel 1a4f096
test(instrumentation-build): remove temporary path rejection test
johanpel 325d1f5
refactor(schema): derive TypeScript path binding
johanpel 41aaff1
docs(schema): clarify path-based APIs
johanpel b30c841
refactor(schema): store path name separately
johanpel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| use quent_schema::visitor::{Cursor, Element, Visitor}; | ||
| use std::collections::HashSet; | ||
|
|
||
| /// Reports paths declared by both a record and an entity. | ||
| #[derive(Default)] | ||
| pub(crate) struct DuplicateTypePaths { | ||
| found: Vec<String>, | ||
| } | ||
|
|
||
| impl Visitor for DuplicateTypePaths { | ||
| type Output = Vec<String>; | ||
|
|
||
| fn visit(&mut self, cursor: &Cursor) { | ||
| let Element::Schema(schema) = cursor.current() else { | ||
| return; | ||
| }; | ||
| let records: HashSet<_> = schema.records().map(|record| record.path()).collect(); | ||
| self.found.extend( | ||
| schema | ||
| .entities() | ||
| .filter(|entity| records.contains(entity.path())) | ||
| .map(|entity| entity.path().to_string()), | ||
| ); | ||
| } | ||
|
|
||
| fn finish(self) -> Self::Output { | ||
| self.found | ||
| } | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
| use quent_schema::test_utils::{entity, event, record, unchecked_schema}; | ||
|
|
||
| #[test] | ||
| fn reports_a_path_used_by_both_type_kinds() { | ||
| let schema = unchecked_schema( | ||
| "Schema", | ||
| [ | ||
| entity("Shared", [event("event", [])]), | ||
| entity("Foo::Q", [event("event", [])]), | ||
| entity("Bar::Q", [event("event", [])]), | ||
| ], | ||
| [ | ||
| record("Shared", []), | ||
| record("Foo::R", []), | ||
| record("Bar::R", []), | ||
| ], | ||
| ); | ||
|
|
||
| assert_eq!( | ||
| schema.walk(DuplicateTypePaths::default()), | ||
| ["Shared".to_string()] | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Records and entities share one type namespace, enforced by builder validation and the new DuplicateTypePaths base constraint.