Skip to content

fix(schema): mark unstable interface versions - #392

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
johanpel:versioning-conventions
Jul 15, 2026
Merged

fix(schema): mark unstable interface versions#392
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
johanpel:versioning-conventions

Conversation

@johanpel

Copy link
Copy Markdown
Contributor

Description

Suggests SemVer identifiers for constraints and renames the collector protobuf package from v1 to v1alpha.

🤖 Generated with Codex

Use SemVer v0.1.0 for constraint identifiers and v1alpha for the collector protobuf package.

🤖 Generated with Codex
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The change updates collector protobuf bindings from v1 to v1alpha and standardizes constraint identifiers and documentation examples on semantic-versioned names such as v0.1.0.

Changes

Collector protobuf namespace

Layer / File(s) Summary
Migrate collector protobuf package
proto/quent/collector/v1alpha/collector.proto, crates/collector/proto/build.rs, proto/src/lib.rs, crates/collector/proto/src/lib.rs
The protobuf package, compilation path, and generated binding targets now use quent.collector.v1alpha.

Constraint identifier versioning

Layer / File(s) Summary
Update constraint names and guidance
crates/constraints/src/lib.rs, crates/fsm/src/lib.rs, crates/ref-target/src/lib.rs, crates/ref-tree/src/lib.rs, crates/resource/src/lib.rs, crates/schema/src/visitor.rs
Constraint naming guidance, examples, built-in identifiers, resource documentation, and the visitor test now use semantic-versioned names such as v0.1.0.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description summarizes the change but omits the required Related Issues, Testing, and Screenshots sections. Add the missing template sections, especially related issues and testing steps; include screenshots only if relevant.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: marking unstable interface versions via SemVer constraints and the collector proto rename.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/resource/src/lib.rs`:
- Line 87: Preserve the persisted key values used by the NAME constants in
crates/resource/src/lib.rs (87-87), crates/ref-target/src/lib.rs (89-89),
crates/fsm/src/lib.rs (184-184), and crates/ref-tree/src/lib.rs (240-240) by
retaining legacy aliases or adding a migration path for any changed keys; add
regression coverage that successfully loads artifacts produced by the prior
commit.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 3f5a663c-84f4-4bf3-98c5-487a36a74240

📥 Commits

Reviewing files that changed from the base of the PR and between 9c29245 and fb2f91a.

📒 Files selected for processing (10)
  • crates/collector/proto/build.rs
  • crates/collector/proto/src/lib.rs
  • crates/constraints/src/lib.rs
  • crates/fsm/src/lib.rs
  • crates/ref-target/src/lib.rs
  • crates/ref-tree/src/lib.rs
  • crates/resource/src/lib.rs
  • crates/schema/src/visitor.rs
  • proto/quent/collector/v1alpha/collector.proto
  • proto/src/lib.rs

impl Resource {
/// The constraint name under which the data is carried.
pub const NAME: &'static str = "quent.resource.v1";
pub const NAME: &'static str = "quent.resource.v0.1.0";

This comment was marked as spam.

@johanpel

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit b68dab1 into rapidsai:main Jul 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants