fix(schema): mark unstable interface versions - #392
Merged
Conversation
Use SemVer v0.1.0 for constraint identifiers and v1alpha for the collector protobuf package. 🤖 Generated with Codex
📝 WalkthroughWalkthroughThe change updates collector protobuf bindings from ChangesCollector protobuf namespace
Constraint identifier versioning
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/resource/src/lib.rs`:
- Line 87: Preserve the persisted key values used by the NAME constants in
crates/resource/src/lib.rs (87-87), crates/ref-target/src/lib.rs (89-89),
crates/fsm/src/lib.rs (184-184), and crates/ref-tree/src/lib.rs (240-240) by
retaining legacy aliases or adding a migration path for any changed keys; add
regression coverage that successfully loads artifacts produced by the prior
commit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: QUIET
Plan: Enterprise
Run ID: 3f5a663c-84f4-4bf3-98c5-487a36a74240
📒 Files selected for processing (10)
crates/collector/proto/build.rscrates/collector/proto/src/lib.rscrates/constraints/src/lib.rscrates/fsm/src/lib.rscrates/ref-target/src/lib.rscrates/ref-tree/src/lib.rscrates/resource/src/lib.rscrates/schema/src/visitor.rsproto/quent/collector/v1alpha/collector.protoproto/src/lib.rs
| impl Resource { | ||
| /// The constraint name under which the data is carried. | ||
| pub const NAME: &'static str = "quent.resource.v1"; | ||
| pub const NAME: &'static str = "quent.resource.v0.1.0"; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
mbrobbel
approved these changes
Jul 15, 2026
Contributor
Author
|
/merge |
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suggests SemVer identifiers for constraints and renames the collector protobuf package from
v1tov1alpha.🤖 Generated with Codex