This repository was archived by the owner on Aug 28, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
feat(conda): port conda recipe to rattler-build #137
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9caa6c8
feat(conda): port conda recipe to rattler-build
gforsyth 518920c
refactor: apply review feedback
gforsyth 6eb430a
chore: remove meta.yaml
gforsyth e348ef7
Merge branch 'main' into rattler
gforsyth bccc918
fix: add `trim` to cuda version load
gforsyth ac452b7
chore: rename to `variants.yaml`
gforsyth 84273b6
chore: add PKG_HASH to build string
gforsyth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,69 @@ | ||||||
| # Copyright (c) 2025, NVIDIA CORPORATION. | ||||||
| schema_version: 1 | ||||||
|
|
||||||
| context: | ||||||
| cuda_version: ${{ load_from_file("pynvjitlink/CUDA_VERSION") | trim }} | ||||||
| date_string: '${{ env.get("RAPIDS_DATE_STRING") }}' | ||||||
| head_rev: ${{ git.head_rev(".")[:8] }} | ||||||
| py_version: ${{ env.get("RAPIDS_PY_VERSION") }} | ||||||
| py_buildstring: ${{ py_version | version_to_buildstring }} | ||||||
| version: ${{ load_from_file("pynvjitlink/VERSION") | trim }} | ||||||
|
|
||||||
| package: | ||||||
| name: pynvjitlink | ||||||
| version: ${{ version }} | ||||||
| source: | ||||||
| path: ../../.. | ||||||
|
|
||||||
| build: | ||||||
| dynamic_linking: | ||||||
| overlinking_behavior: error | ||||||
| string: ${{ cuda_version }}_py${{ py_buildstring }}_${{ date_string }}_${{ head_rev }}_h${{ PKG_HASH }} | ||||||
| script: | ||||||
| content: | | ||||||
| python -m pip install . -vv | ||||||
| secrets: | ||||||
| - AWS_ACCESS_KEY_ID | ||||||
| - AWS_SECRET_ACCESS_KEY | ||||||
| - AWS_SESSION_TOKEN | ||||||
| env: | ||||||
| CMAKE_C_COMPILER_LAUNCHER: ${{ env.get("CMAKE_C_COMPILER_LAUNCHER") }} | ||||||
| CMAKE_CUDA_COMPILER_LAUNCHER: ${{ env.get("CMAKE_CUDA_COMPILER_LAUNCHER") }} | ||||||
| CMAKE_CXX_COMPILER_LAUNCHER: ${{ env.get("CMAKE_CXX_COMPILER_LAUNCHER") }} | ||||||
| CMAKE_GENERATOR: ${{ env.get("CMAKE_GENERATOR") }} | ||||||
| SCCACHE_BUCKET: ${{ env.get("SCCACHE_BUCKET") }} | ||||||
| SCCACHE_IDLE_TIMEOUT: ${{ env.get("SCCACHE_IDLE_TIMEOUT") }} | ||||||
| SCCACHE_REGION: ${{ env.get("SCCACHE_REGION") }} | ||||||
| SCCACHE_S3_USE_SSL: ${{ env.get("SCCACHE_S3_USE_SSL") }} | ||||||
| SCCACHE_S3_NO_CREDENTIALS: ${{ env.get("SCCACHE_S3_NO_CREDENTIALS") }} | ||||||
| SCCACHE_S3_KEY_PREFIX: pynvjitlink/${{ env.get("RAPIDS_CONDA_ARCH") }}/cuda${{ cuda_major }} | ||||||
|
|
||||||
| requirements: | ||||||
| build: | ||||||
| - ${{ compiler("c") }} | ||||||
| - ${{ compiler("cxx") }} | ||||||
| - ${{ compiler("cuda") }} | ||||||
| - ${{ stdlib("c") }} | ||||||
| - cmake >=3.24.4,!=3.30.0 | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We bumped this for the rest of RAPIDS. Probably wouldn't hurt to match here since it's just a build-time requirement.
Suggested change
|
||||||
| - ninja | ||||||
| host: | ||||||
| - cuda-version =${{ cuda_version }} | ||||||
| - libnvjitlink-dev | ||||||
| - libnvjitlink-static | ||||||
| - python =${{ py_version }} | ||||||
| - pip | ||||||
| - rapids-build-backend >=0.3.0,<0.4.0dev0 | ||||||
| - scikit-build-core >=0.10.0 | ||||||
| run: | ||||||
| - ${{ pin_compatible("cuda-version", lower_bound="x", upper_bound="x.x") }} | ||||||
| - python | ||||||
| - numba >=0.58 | ||||||
| ignore_run_exports: | ||||||
| by_name: | ||||||
| - cuda-version | ||||||
| - libnvjitlink | ||||||
|
|
||||||
| about: | ||||||
| homepage: ${{ load_from_file("pyproject.toml").project.urls.Homepage }} | ||||||
| license: ${{ load_from_file("pyproject.toml").project.license.text }} | ||||||
| summary: ${{ load_from_file("pyproject.toml").project.description }} | ||||||
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done to ensure
cuda_compiler_versionmatched the intendedCUDA_VERSIONset in that file. That is the one canonical place used to CUDA version in this feedstock. It is also used by wheels to install the right Linux CUDA packages when building as wellAdditionally setting
cuda_compiler_versionthis way ensured it was considered when generating the package string hash. Mayberattler-buildhandles this differentlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can load it from the file directly and make sure it's part of the package string