Skip to content

mark 'packaging' as test-only dependency - #88

Merged
rapids-bot[bot] merged 3 commits into
rapidsai:release/26.04from
jameslamb:misc-packaging
Mar 20, 2026
Merged

mark 'packaging' as test-only dependency#88
rapids-bot[bot] merged 3 commits into
rapidsai:release/26.04from
jameslamb:misc-packaging

Conversation

@jameslamb

Copy link
Copy Markdown
Member

packaging is only used in docs builds:

from packaging.version import Version

and tests:

from packaging.version import Version

It doesn't need to be declared as a runtime dependency of nvforest. This moves it to a test-time-only dependency.

@jameslamb
jameslamb requested a review from a team as a code owner March 18, 2026 04:44
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 18, 2026
@github-actions github-actions Bot added conda Relates to conda packaging Cython / Python labels Mar 18, 2026
@coderabbitai

coderabbitai Bot commented Mar 18, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 113017f2-47f0-4cdf-b7e1-93cd0f1b4523

📥 Commits

Reviewing files that changed from the base of the PR and between cbdf009 and 35db512.

📒 Files selected for processing (2)
  • dependencies.yaml
  • python/nvforest/pyproject.toml
✅ Files skipped from review due to trivial changes (1)
  • python/nvforest/pyproject.toml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Reorganized dependency management across conda and Python configurations for improved maintainability.
    • Moved the packaging dependency from runtime to test-only dependencies.
    • Simplified dependency declarations by removing redundant anchoring and shared-definition patterns.

Walkthrough

Removed packaging from primary runtime/build dependencies and consolidated it as a test/docs-shared dependency; also removed YAML anchors for cython and numpy, replacing them with plain entries in the dependencies manifest and moved packaging into test optional-dependencies in the Python project config.

Changes

Cohort / File(s) Summary
Conda recipe
conda/recipes/nvforest/recipe.yaml
Removed packaging from host/run requirements.
YAML dependency manifests
dependencies.yaml
Removed &cython anchor from cython>=3.0.0 and &numpy anchor from numpy>=1.23,<3.0a0; introduced &packaging packaging under docs.common.packages; removed packaging from py_run_nvforest.common.packages and added it to test_python.common.packages via *packaging.
Python project metadata
python/nvforest/pyproject.toml
Deleted packaging from [project].dependencies and added it to [project.optional-dependencies].test.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • gforsyth
  • AyodeAwe
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: reclassifying 'packaging' from a runtime dependency to a test-only dependency across all configuration files.
Description check ✅ Passed The description is clearly related to the changeset, explaining why 'packaging' is being moved to a test-only dependency with specific references to its usage in docs and tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@gforsyth gforsyth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jameslamb

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit da53069 into rapidsai:release/26.04 Mar 20, 2026
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conda Relates to conda packaging Cython / Python improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants