Skip to content

[Don't merge] Require XGBoost >= 3.4.0 - #191

Open
trivialfis wants to merge 2 commits into
rapidsai:mainfrom
trivialfis:test_xgboost340
Open

[Don't merge] Require XGBoost >= 3.4.0#191
trivialfis wants to merge 2 commits into
rapidsai:mainfrom
trivialfis:test_xgboost340

Conversation

@trivialfis

Copy link
Copy Markdown
Member

No description provided.

@trivialfis
trivialfis requested a review from a team as a code owner August 11, 2026 06:04
@github-actions github-actions Bot added the conda Relates to conda packaging label Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c85d64f5-ecb1-4eb9-be84-359b920718dd

📥 Commits

Reviewing files that changed from the base of the PR and between ff7e294 and a19b43b.

📒 Files selected for processing (2)
  • dependencies.yaml
  • python/nvforest/pyproject.toml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated supported CUDA environment configurations to require XGBoost 3.4.0 or newer.
    • Applied the dependency update across ARM64 and x86_64 platforms for CUDA 12.9 and 13.3.
    • Updated standard Python dependency requirements and Python 3.12+ testing requirements to use XGBoost 3.4.0 or newer.

Walkthrough

The repository raises the minimum XGBoost version from 3.3.0 to 3.4.0 in dependency declarations, CUDA environment definitions, and Python test configuration.

Changes

XGBoost dependency update

Layer / File(s) Summary
Update dependency declarations
dependencies.yaml, python/nvforest/pyproject.toml
Conda, CUDA-specific, unsuffixed Python, and Python 3.12+ test requirements now require xgboost>=3.4.0.
Update CUDA environment constraints
conda/environments/all_cuda-129_arch-*, conda/environments/all_cuda-133_arch-*
All four CUDA environment definitions now require xgboost>=3.4.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: improvement

Suggested reviewers: kylefromnvidia

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so its relevance to the changeset cannot be assessed. Add a brief description that states the XGBoost minimum-version updates and the affected dependency files.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: requiring XGBoost version 3.4.0 or newer.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conda Relates to conda packaging Cython / Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants