Improve devcontainer startup times - #123
Merged
Merged
Conversation
…ve devcontainer startup times
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates devcontainer configurations to use Docker build caching and adds a GitHub Actions workflow job to automatically build and publish devcontainer images for CUDA 12.9 and 13.2 variants. ChangesDevContainer Build Cache and CI Integration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build.yaml:
- Around line 189-197: The devcontainers job (named "devcontainers" with push:
true) must be gated on successful wheel publish jobs; add a needs: key to the
devcontainers job listing the wheel build/publish job IDs (e.g., the job names
that build and publish wheels such as build-wheels or publish-wheels) so the
devcontainers job only runs after those wheel jobs succeed, keeping the existing
permissions and with: push: true unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: d56a11a1-762d-41df-bf71-f968cea6c461
📒 Files selected for processing (5)
.devcontainer/cuda12.9-conda/devcontainer.json.devcontainer/cuda12.9-pip/devcontainer.json.devcontainer/cuda13.2-conda/devcontainer.json.devcontainer/cuda13.2-pip/devcontainer.json.github/workflows/build.yaml
jameslamb
approved these changes
May 20, 2026
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds and publishes devcontainers to
ghcr.ioand uses the new images to improve CI and local devcontainer startup times.In
rapidsai/devcontainers, devcontainer startup times went from3m28sto34s.Contributes to rapidsai/build-planning#280.