Use static cudart - #112
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughRemoves the ChangesCUDA static runtime hardening
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cpp/CMakeLists.txt`:
- Around line 297-301: The current INTERFACE $<COMPILE_ONLY:CUDA::cudart_static>
on target_link_libraries for ${NVFOREST_CPP_TARGET} only propagates compile info
and will break static consumers at link time; change that generator expression
to a conditional one that applies LINK_ONLY:CUDA::cudart_static when the
consuming target is a static library and omits the CUDA runtime for shared
builds (i.e., replace the COMPILE_ONLY use with a conditional generator
expression that yields $<LINK_ONLY:CUDA::cudart_static> for static-type
consumers of ${NVFOREST_CPP_TARGET} and nothing for shared).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7dac64f1-41cb-4fad-b406-4bfd5cae8bb5
📒 Files selected for processing (1)
cpp/CMakeLists.txt
|
/merge |
Issue: rapidsai/build-planning#235