Explicitly manage TLS/SSL CA paths for remote I/O#817
Merged
rapids-bot[bot] merged 12 commits intorapidsai:branch-25.10from Sep 15, 2025
Merged
Explicitly manage TLS/SSL CA paths for remote I/O#817rapids-bot[bot] merged 12 commits intorapidsai:branch-25.10from
rapids-bot[bot] merged 12 commits intorapidsai:branch-25.10from
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 9cb4137 |
Contributor
Author
VerificationA
The toy program is able to locate and use the correct certificate in all the conditions above. |
|
|
||
| void set_up_ca_paths(CurlHandle& curl) | ||
| { | ||
| static auto const [ca_bundle_file, ca_directory] = get_ca_paths(); |
Contributor
Author
There was a problem hiding this comment.
static structured binding is not supported in C++17, and this helped to identify an oversight to be fixed by #819.
Contributor
Author
|
/ok to test 1903a7b |
Contributor
Author
|
/merge |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
libcurlhave two path parameters related to the certificate authority (CA):CURLOPT_CAINFO, which specifies the CA bundle file path.CURLOPT_CAPATH, which specifies the directory of individual CA certificates with hash-based naming.The default paths are determined at compile-time, which can cause issues if the Linux distributions where
libcurlis built and run are different (e.g. on Rocky Linux vs Ubuntu as in our CI vs our lab system), and the certificates files are likely at different locations. This problem has been observed in KvikIO's wheel distribution, where HTTPS would fail with the message:This PR
This PR addresses this problem. The certificate path is now explicitly searched for in the following order. The compile-time parameters, if any, are still used but treated with lowest priority.
CURL_CA_BUNDLE, andSSL_CERT_FILESSL_CERT_DIRDepends on #819 for the use of
staticstructured binding which is only available in C++ >=20Closes #711