Use C++20 standard#749
Merged
rapids-bot[bot] merged 16 commits intorapidsai:branch-25.10from Jul 25, 2025
Merged
Conversation
kingcrimsontianyu
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
madsbk
approved these changes
Jun 25, 2025
bdice
requested changes
Jun 25, 2025
cpp/benchmarks/CMakeLists.txt
Outdated
| PROPERTIES INSTALL_RPATH "\$ORIGIN/../../../lib" | ||
| CXX_STANDARD 20 | ||
| CXX_STANDARD_REQUIRED ON | ||
| # For std:: support of __int128_t. Can be removed once using cuda::std |
Contributor
There was a problem hiding this comment.
What actions do we need to take here? Where does kvikio use __int128_t? I think we want to move to cuda::std or remove the CXX_EXTENSIONS ON if not needed.
Contributor
There was a problem hiding this comment.
Please also remove this from cpp/tests/CMakeLists.txt, it seems like a copy-paste from cudf that is unnecessary in kvikio.
Contributor
Author
There was a problem hiding this comment.
Thanks. Done.
bdice
reviewed
Jun 25, 2025
cpp/benchmarks/CMakeLists.txt
Outdated
| PROPERTIES INSTALL_RPATH "\$ORIGIN/../../../lib" | ||
| CXX_STANDARD 20 | ||
| CXX_STANDARD_REQUIRED ON | ||
| CXX_EXTENSIONS ON |
Contributor
There was a problem hiding this comment.
Please remove this. This was the line indicated by the comment about int128 support.
Suggested change
| CXX_EXTENSIONS ON |
Contributor
Author
There was a problem hiding this comment.
I see. Done.
bdice
reviewed
Jun 25, 2025
cpp/tests/CMakeLists.txt
Outdated
| CXX_STANDARD 20 | ||
| CXX_STANDARD_REQUIRED ON | ||
| # For std:: support of __int128_t. Can be removed once using cuda::std | ||
| CXX_EXTENSIONS ON |
Contributor
There was a problem hiding this comment.
Suggested change
| CXX_EXTENSIONS ON |
bdice
approved these changes
Jun 25, 2025
bdice
reviewed
Jul 21, 2025
vyasr
reviewed
Jul 25, 2025
Contributor
Author
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/rapidsmpf
that referenced
this pull request
Jul 28, 2025
Building 25.10 wheels packages fail due to the use of GCC 14, rapidsai/kvikio#749 implements a fix for that case that will probably fix it here as well. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #396
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
Previous PR #749 forgets to bring the entrée to the table: Only the C++ code in tests and benchmarks use C++20, but not the main library. This PR fixes this oversight. Authors: - Tianyu Liu (https://github.com/kingcrimsontianyu) Approvers: - Mads R. B. Kristensen (https://github.com/madsbk) URL: #819
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes KvikIO C++ standard from 17 to 20.
Depends on #751