Skip to content

Fix conda recipe for kvikio #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 4 commits into from
May 16, 2024
Merged

Fix conda recipe for kvikio #381

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
515fb49
Fix conda recipe for kvikio
KyleFromNVIDIA May 15, 2024
2e7058f
Remove extra -DKVIKIO_FIND_CPP
KyleFromNVIDIA May 16, 2024
030ff05
Add verbose flag to Python Conda build
KyleFromNVIDIA May 16, 2024
e379941
Revert "Add verbose flag to Python Conda build"
KyleFromNVIDIA May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,11 @@ if hasArg -n; then
INSTALL_TARGET=""
fi

# Append `-DFIND_KVIKIO_CPP=ON` to EXTRA_CMAKE_ARGS unless a user specified the option.
if [[ "${EXTRA_CMAKE_ARGS}" != *"DFIND_KVIKIO_CPP"* ]]; then
EXTRA_CMAKE_ARGS="${EXTRA_CMAKE_ARGS} -DFIND_KVIKIO_CPP=ON"
fi

# If clean given, run it prior to any other steps
if hasArg clean; then
# If the dirs to clean are mounted dirs in a container, the
Expand Down Expand Up @@ -147,6 +152,6 @@ fi
if (( NUMARGS == 0 )) || hasArg kvikio; then
echo "building kvikio..."
cd ${REPODIR}/python
SKBUILD_CMAKE_ARGS="-DCMAKE_PREFIX_PATH=${INSTALL_PREFIX};-DCMAKE_LIBRARY_PATH=${LIBKVIKIO_BUILD_DIR};${EXTRA_CMAKE_ARGS}" \
SKBUILD_CMAKE_ARGS="-DCMAKE_PREFIX_PATH=${INSTALL_PREFIX};-DCMAKE_LIBRARY_PATH=${LIBKVIKIO_BUILD_DIR};-DFIND_KVIKIO_CPP=ON;${EXTRA_CMAKE_ARGS}" \
Comment thread
KyleFromNVIDIA marked this conversation as resolved.
Outdated
python -m pip install --no-build-isolation --no-deps .
fi
4 changes: 4 additions & 0 deletions conda/recipes/kvikio/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/bin/bash
# Copyright (c) 2018-2024, NVIDIA CORPORATION.

./build.sh kvikio
3 changes: 0 additions & 3 deletions conda/recipes/kvikio/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ build:
- SCCACHE_S3_KEY_PREFIX=kvikio-linux64 # [linux64]
- SCCACHE_S3_USE_SSL
- SCCACHE_S3_NO_CREDENTIALS
script:
- cd python
- python -m pip install . -vv
ignore_run_exports_from:
{% if cuda_major == "11" %}
- {{ compiler('cuda11') }}
Expand Down