Skip to content

ensure nightly builds always produce new packages #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 6 commits into from
Aug 7, 2026
Merged

ensure nightly builds always produce new packages #863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b8168e
ensure nightly builds always produce new packages
jameslamb Aug 4, 2026
67e6063
more updates
jameslamb Aug 4, 2026
fc1e42f
fix conflicts
jameslamb Aug 4, 2026
1190fd9
duplicate workflows
jameslamb Aug 4, 2026
1b84507
Merge branch 'main' of github.com:rapidsai/integration into nightly-v…
jameslamb Aug 6, 2026
992f634
empty commit to re-trigger CI
jameslamb Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,15 @@ concurrency:
permissions: {}

jobs:
build-details:
uses: rapidsai/shared-workflows/.github/workflows/compute-build-details.yaml@main
build:
needs: [build-details]
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@main
with:
build_type: ${{ inputs.build_type || 'branch' }}
build-datetime: ${{ needs.build-details.outputs.build-datetime }}
branch: ${{ inputs.branch }}
date: ${{ inputs.date }}
script: ci/build_python.sh
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,15 @@ jobs:
pr-builder:
needs:
- build
- build-details
- checks
- check-nightly-ci
- test-conda-nightly-env
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@main
permissions:
contents: read
build-details:
uses: rapidsai/shared-workflows/.github/workflows/compute-build-details.yaml@main
check-nightly-ci:
runs-on: ubuntu-latest
permissions:
Expand Down Expand Up @@ -51,11 +54,12 @@ jobs:
persist-credentials: false
- uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1
build:
needs: checks
needs: [build-details, checks]
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@main
with:
build_type: pull-request
build-datetime: ${{ needs.build-details.outputs.build-datetime }}
script: ci/build_python.sh
pure-conda: cuda_major
permissions:
Expand Down
4 changes: 2 additions & 2 deletions ci/build_python.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
#!/bin/bash
# Copyright (c) 2022-2025, NVIDIA CORPORATION.
# Copyright (c) 2022-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.

set -euo pipefail

source rapids-configure-sccache

source rapids-date-string
source rapids-datetime-string

RAPIDS_PACKAGE_VERSION=$(rapids-generate-version)
export RAPIDS_PACKAGE_VERSION
Expand Down
12 changes: 6 additions & 6 deletions ci/check_conda_nightly_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2024-2025, NVIDIA CORPORATION.
# Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
import json
import re
import sys
Expand Down Expand Up @@ -33,16 +33,16 @@ def get_package_date(package):
if package["name"] in EXCLUDED_PACKAGES:
return None

# Matches 6 digits starting with "2", which should be YYMMDD
date_re = r"(?:^|_)(2\d{5})_"
# Matches 12 digits starting with "2", which should be YYMMDDhhmmss
date_re = r"(?:^|_)(2\d{11})_"

@jameslamb jameslamb Aug 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing doing this in the same PR to also test that all RAPIDS packages have appropriately-updated version components.

That'll mean this is the last PR in the series to merge, I think that's totally fine.

@jameslamb jameslamb Aug 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last PR in the series to merge

Looks like just cuml is left!

Date string not found for libcuml in the build string 'cuda13_260806_fbe8dbe5'.
Date string not found for cuml in the build string 'cuda13_cp311_abi3_260806_fbe8dbe5'.

Error: The following packages are missing dates in their build strings:
 - cuml
 - libcuml

(build link)

NVIDIA/cuml#8448 just merged a few minutes ago

As soon as its main build finishes (https://github.com/rapidsai/cuml/actions/runs/31135338229), CI should pass on a re-run here 😁

@KyleFromNVIDIA KyleFromNVIDIA Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This date string hard-codes the number 2 at the beginning. Do you have a plan to deal with the Y3K problem? 😁

@jameslamb jameslamb Aug 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw it on the backlog 😛


# Use regex to find the date string in the input
match = re.search(date_re, package["build_string"])

if match:
# Convert the date string to a datetime object
date_string = match.group(1)
date_object = datetime.strptime(date_string, "%y%m%d")
# Convert the date-time string to a datetime object
datetime_string = match.group(1)
date_object = datetime.strptime(datetime_string, "%y%m%d%H%M%S")
return date_object

print(
Expand Down
4 changes: 2 additions & 2 deletions conda/recipes/rapids-xgboost/recipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ context:
rapids_version: ${{ env.get("RAPIDS_PACKAGE_VERSION") }}
cuda_version: ${{ (env.get("RAPIDS_CUDA_VERSION") | split("."))[:2] | join(".") }}
cuda_major: '${{ (env.get("RAPIDS_CUDA_VERSION") | split("."))[0] }}'
date_string: '${{ env.get("RAPIDS_DATE_STRING") }}'
datetime_string: '${{ env.get("RAPIDS_DATETIME_STRING") }}'
head_rev: ${{ git.head_rev(".")[:8] }}

package:
Expand All @@ -17,7 +17,7 @@ source:

build:
noarch: python
string: cuda${{ cuda_major }}_${{ date_string }}_${{ head_rev }}
string: cuda${{ cuda_major }}_${{ datetime_string }}_${{ head_rev }}

requirements:
host:
Expand Down
4 changes: 2 additions & 2 deletions conda/recipes/rapids/recipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ context:
minor_version: ${{ (version | split("."))[:2] | join(".") }}
cuda_version: ${{ (env.get("RAPIDS_CUDA_VERSION") | split("."))[:2] | join(".") }}
cuda_major: '${{ (env.get("RAPIDS_CUDA_VERSION") | split("."))[0] }}'
date_string: '${{ env.get("RAPIDS_DATE_STRING") }}'
datetime_string: '${{ env.get("RAPIDS_DATETIME_STRING") }}'
head_rev: ${{ git.head_rev(".")[:8] }}

package:
Expand All @@ -18,7 +18,7 @@ source:

build:
noarch: python
string: cuda${{ cuda_major }}_${{ date_string }}_${{ head_rev }}
string: cuda${{ cuda_major }}_${{ datetime_string }}_${{ head_rev }}

requirements:
host:
Expand Down
Loading