Skip to content

Add Python 3.9 support to rapids-build-env packages - #400

Merged
jjacobelli merged 17 commits into
rapidsai:branch-22.02from
msadang:python39-support
Jan 18, 2022
Merged

Add Python 3.9 support to rapids-build-env packages#400
jjacobelli merged 17 commits into
rapidsai:branch-22.02from
msadang:python39-support

Conversation

@msadang

@msadang msadang commented Nov 29, 2021 •
edited by jjacobelli
Loading

Copy link
Copy Markdown
Contributor

Add Python 3.9 support to rapids-build-env packages:

  • Adding python 3.9 to nigthly-env axis files
  • Upgrading required packages
  • Removing fa2 as the package is not used/maintained anymore and does not support python 3.9
  • Adding Python 3.8 to tests matrix to prepare for Python 3.7 removing

@msadang
msadang requested a review from a team as a code owner November 29, 2021 22:19
@rapidsai rapidsai deleted a comment from msadang Nov 30, 2021
ajschmidt8
ajschmidt8 previously requested changes Nov 30, 2021
View reviewed changes
Comment thread ci/axis/tests.yaml Outdated
msadang and others added 3 commits November 30, 2021 12:11
@msadang @ajschmidt8
Update ci/axis/tests.yaml
e392f84 
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@msadang
change python version order
cd7946a
@msadang
Merge branch 'python39-support' of https://github.com/msadang/integra…
845b894 
…tion into python39-support
@msadang msadang added the 2 - In Progress Currenty a work in progress label Dec 6, 2021
@msadang
msadang dismissed ajschmidt8’s stale review December 6, 2021 20:02

Changes completed

@msadang msadang self-assigned this Dec 6, 2021
@msadang

msadang commented Dec 7, 2021

Copy link
Copy Markdown
Contributor Author

rerun tests

ajschmidt8
ajschmidt8 reviewed Jan 10, 2022
View reviewed changes
Comment thread conda/recipes/versions.yaml
msadang and others added 2 commits January 10, 2022 12:57
@msadang
remove fa2 package
adfcd82 
fa2 deprecated, no longer being maintained
@msadang
add python 3.0 to tests
1ed8fcd
@jjacobelli

jjacobelli commented Jan 11, 2022

Copy link
Copy Markdown
Contributor

It seems like we need to upgrade ipython to a newer version as version 7.15 does not have python 3.9 packages: https://anaconda.org/conda-forge/ipython/files?version=7.15.0

@jjacobelli

jjacobelli commented Jan 11, 2022

Copy link
Copy Markdown
Contributor

We also need to update the PR to match the changes made by #406
We should only add python 3.9 in the nightly-env-arm64.yaml and nightly-env.yaml files

@msadang

msadang commented Jan 14, 2022

Copy link
Copy Markdown
Contributor Author

rerun tests

@jjacobelli

jjacobelli commented Jan 17, 2022

Copy link
Copy Markdown
Contributor

rerun tests

@jjacobelli
Update axis files for python 3.9
4ffa1e1 
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli jjacobelli changed the title updated yaml files to remove 3.7 and include 3.9 Add Python 3.9 support to rapids-build-env packages Jan 18, 2022
@jjacobelli
jjacobelli merged commit 3986715 into rapidsai:branch-22.02 Jan 18, 2022
@raydouglass raydouglass mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@msadang msadang

Labels

2 - In Progress Currenty a work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msadang @jjacobelli @ajschmidt8 @raydouglass