Pinning spdlog version to 1.8.5 - #318
Merged
Merged
Conversation
jakirkham
reviewed
Jul 21, 2021
jakirkham
approved these changes
Jul 21, 2021
rapids-bot Bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Jul 21, 2021
spdlog 1.9 conda package was released yesterday and it's causing compile issues on cuml. We're also pinning it in the integrations repo: rapidsai/integration#318. Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Mark Harris (https://github.com/harrism) - Joseph (https://github.com/jolorunyomi) URL: #831
Member
|
@rapidsai/ops-codeowners the PR in RMM has been merged, can this PR be approved/merged to unblock cuML? |
ajschmidt8
approved these changes
Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new conda package for spdlog was released last night and it's causing a build issue in cuml. We've decided to pin the version to 1.8.5 in the meantime to unblock CI (and potentially for release 21.08).
NVIDIA/cuml#4078